Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 227553010: Revert of Initial picture shader implementation (Closed)

Created:
6 years, 8 months ago by benchen
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of Initial picture shader implementation (https://codereview.chromium.org/221923007/) Reason for revert: breaking the buildbots. Subsequent CL only addressed CompareGMs but GenerateGMs are also failing. Original issue's description: > Initial picture shader implementation > > This CL adds an SkPictureShader class to support SkPicture-based > patterns. > > The implementation renders the picture into an SkBitmap tile and then > delegates to SkBitmapProcShader for the actual operation. > > R=reed@google.com,robertphillips@google.com,bsalomon@google.com > > Committed: http://code.google.com/p/skia/source/detail?r=14085 TBR=bsalomon@google.com,reed@google.com,robertphillips@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -430 lines) Patch
D gm/pictureshader.cpp View 1 chunk +0 lines, -165 lines 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkShader.h View 2 chunks +0 lines, -11 lines 0 comments Download
D src/core/SkPictureShader.h View 1 chunk +0 lines, -60 lines 0 comments Download
D src/core/SkPictureShader.cpp View 1 chunk +0 lines, -185 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
benchen
Created Revert of Initial picture shader implementation
6 years, 8 months ago (2014-04-07 23:45:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/227553010/1
6 years, 8 months ago (2014-04-07 23:45:22 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 23:46:01 UTC) #3
Message was sent while issue was closed.
Change committed as 14087

Powered by Google App Engine
This is Rietveld 408576698