Replace ASSERT*() with DCHECK*() in core/events/.

Replace ASSERT*() with DCHECK*() in core/events/.

This CL has no behavior changes.

BUG=596760
Committed: https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c
Cr-Commit-Position: refs/heads/master@{#414015}

[tkent, 2016-08-24 00:51:54]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2016-08-24 00:51:59]

Description was changed from

==========
Replace ASSERT*() with DCHECK*() in core/events/.

BUG=
==========

to

==========
Replace ASSERT*() with DCHECK*() in core/events/.

This CL has no behavior changes.

BUG=596760
==========

[commit-bot: I haz the power, 2016-08-24 00:52:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 01:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 01:06:36]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[tkent, 2016-08-24 02:02:30]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 02:03:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-24 02:04:50]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-24 02:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 02:21:11]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[tkent, 2016-08-24 02:32:39]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 02:33:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-24 03:12:44]

Patchset #1 (id:20001) has been deleted

[tkent, 2016-08-24 03:24:22]

tkent@chromium.org changed reviewers:
+ hayato@chromium.org

[tkent, 2016-08-24 03:24:23]

hayato@, would you review this please?

[hayato, 2016-08-24 03:42:27]

lgtm

https://codereview.chromium.org/2270293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/TreeScopeEventContext.h (right):

https://codereview.chromium.org/2270293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TreeScopeEventContext.h:111:
DCHECK(target);
You do not have to guard DCHECK(target) by DCHECK_IS_ON.

https://codereview.chromium.org/2270293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TreeScopeEventContext.h:120:
DCHECK(relatedTarget);
You do not have to guard DCHECK(relataedTarget) by DCHECK_IS_ON.

[tkent, 2016-08-24 05:59:43]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 06:00:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-24 06:05:23]

https://codereview.chromium.org/2270293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/TreeScopeEventContext.h (right):

https://codereview.chromium.org/2270293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TreeScopeEventContext.h:111:
DCHECK(target);
On 2016/08/24 at 03:42:27, hayato wrote:
> You do not have to guard DCHECK(target) by DCHECK_IS_ON.

You're right.

I reconsidered isUnreachableNode(), which is available only in DCHECK_IS_ON(),
and changed my approach.  Please take another look at new patch set.  I changed
isUnreachableNode() to checkReachableNode().

[hayato, 2016-08-24 06:10:41]

On 2016/08/24 at 06:05:23, tkent wrote:
>
https://codereview.chromium.org/2270293002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/events/TreeScopeEventContext.h (right):
> 
>
https://codereview.chromium.org/2270293002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/TreeScopeEventContext.h:111:
DCHECK(target);
> On 2016/08/24 at 03:42:27, hayato wrote:
> > You do not have to guard DCHECK(target) by DCHECK_IS_ON.
> 
> You're right.
> 
> I reconsidered isUnreachableNode(), which is available only in DCHECK_IS_ON(),
and changed my approach.  Please take another look at new patch set.  I changed
isUnreachableNode() to checkReachableNode().

Looks good. LGTM

[commit-bot: I haz the power, 2016-08-24 07:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 07:37:59]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-08-24 08:03:12]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-08-24 08:03:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 08:08:20]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-08-24 08:10:55]

Description was changed from

==========
Replace ASSERT*() with DCHECK*() in core/events/.

This CL has no behavior changes.

BUG=596760
==========

to

==========
Replace ASSERT*() with DCHECK*() in core/events/.

This CL has no behavior changes.

BUG=596760

Committed: https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c
Cr-Commit-Position: refs/heads/master@{#414015}
==========

[commit-bot: I haz the power, 2016-08-24 08:10:56]

Patchset 2 (id:??) landed as
https://crrev.com/a9838bdfb2709677aacdad97fdd2ede40b49420c
Cr-Commit-Position: refs/heads/master@{#414015}