Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: third_party/WebKit/Source/core/events/EventPath.h

Issue 2270293002: Replace ASSERT*() with DCHECK*() in core/events/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: isUnreachableNode -> checkReachableNode Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/EventPath.h
diff --git a/third_party/WebKit/Source/core/events/EventPath.h b/third_party/WebKit/Source/core/events/EventPath.h
index 6f771758a24dab1d2a3ccdd393ffff74fa8eb7b1..486afab09fa2416fcb298940b7b1173c6cac585c 100644
--- a/third_party/WebKit/Source/core/events/EventPath.h
+++ b/third_party/WebKit/Source/core/events/EventPath.h
@@ -56,7 +56,7 @@ public:
NodeEventContext& at(size_t index) { return m_nodeEventContexts[index]; }
NodeEventContext& last() { return m_nodeEventContexts[size() - 1]; }
- WindowEventContext& windowEventContext() { ASSERT(m_windowEventContext); return *m_windowEventContext; }
+ WindowEventContext& windowEventContext() { DCHECK(m_windowEventContext); return *m_windowEventContext; }
void ensureWindowEventContext();
bool isEmpty() const { return m_nodeEventContexts.isEmpty(); }
@@ -82,7 +82,7 @@ private:
void calculateAdjustedTargets();
void calculateTreeOrderAndSetNearestAncestorClosedTree();
- void shrink(size_t newSize) { ASSERT(!m_windowEventContext); m_nodeEventContexts.shrink(newSize); }
+ void shrink(size_t newSize) { DCHECK(!m_windowEventContext); m_nodeEventContexts.shrink(newSize); }
void retargetRelatedTarget(const Node& relatedTargetNode);
@@ -98,7 +98,7 @@ private:
static void buildRelatedNodeMap(const Node&, RelatedTargetMap&);
static EventTarget* findRelatedNode(TreeScope&, RelatedTargetMap&);
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
static void checkReachability(TreeScope&, TouchList&);
#endif
« no previous file with comments | « third_party/WebKit/Source/core/events/EventListenerMap.cpp ('k') | third_party/WebKit/Source/core/events/EventPath.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698