Replace ASSERT*() with DCHECK*() in core/events/.

third_party/WebKit/Source/core/events/TreeScopeEventContext.h

 /*
  * Copyright (C) 2014 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 46 matching lines @@
     EventTarget* relatedTarget() const { return m_relatedTarget.get(); }
     void setRelatedTarget(EventTarget*);
 
     TouchEventContext* touchEventContext() const { return m_touchEventContext.get(); }
     TouchEventContext* ensureTouchEventContext();
 
     HeapVector<Member<EventTarget>>& ensureEventPath(EventPath&);
 
     bool isInclusiveAncestorOf(const TreeScopeEventContext&) const;
     bool isDescendantOf(const TreeScopeEventContext&) const;
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
     bool isExclusivePartOf(const TreeScopeEventContext&) const;
 #endif
     void addChild(TreeScopeEventContext& child) { m_children.append(&child); }
 
     // For ancestor-descendant relationship check in O(1).
     // Preprocessing takes O(N).
     int calculateTreeOrderAndSetNearestAncestorClosedTree(int orderNumber, TreeScopeEventContext* nearestAncestorClosedTreeScopeEventContext);
 
     TreeScopeEventContext* containingClosedShadowTree() const { return m_containingClosedShadowTree.get(); }
 
 private:
     TreeScopeEventContext(TreeScope&);
 
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
     bool isUnreachableNode(EventTarget&);
 #endif
 
     bool isUnclosedTreeOf(const TreeScopeEventContext& other);
 
     Member<TreeScope> m_treeScope;
     Member<Node> m_rootNode; // Prevents TreeScope from being freed. TreeScope itself isn't RefCounted.
     Member<EventTarget> m_target;
     Member<EventTarget> m_relatedTarget;
     Member<HeapVector<Member<EventTarget>>> m_eventPath;
     Member<TouchEventContext> m_touchEventContext;
     Member<TreeScopeEventContext> m_containingClosedShadowTree;
 
     HeapVector<Member<TreeScopeEventContext>> m_children;
     int m_preOrder;
     int m_postOrder;
 };
 
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
 inline bool TreeScopeEventContext::isUnreachableNode(EventTarget& target)
 {
     // FIXME: Checks also for SVG elements.
     return target.toNode() && !target.toNode()->isSVGElement() && !target.toNode()->treeScope().isInclusiveOlderSiblingShadowRootOrAncestorTreeScopeOf(treeScope());
 }
 #endif
 
 inline void TreeScopeEventContext::setTarget(EventTarget* target)
 {
-    ASSERT(target);
-    ASSERT(!isUnreachableNode(*target));
+#if DCHECK_IS_ON()
+    DCHECK(target);

[hayato, 2016/08/24 03:42:27]

You do not have to guard DCHECK(target) by DCHECK_IS_ON.

[tkent, 2016/08/24 06:05:23]

You're right.

I reconsidered isUnreachableNode(), which is available only in DCHECK_IS_ON(),
and changed my approach.  Please take another look at new patch set.  I changed
isUnreachableNode() to checkReachableNode().

+    DCHECK(!isUnreachableNode(*target));
+#endif
     m_target = target;
 }
 
 inline void TreeScopeEventContext::setRelatedTarget(EventTarget* relatedTarget)
 {
-    ASSERT(relatedTarget);
-    ASSERT(!isUnreachableNode(*relatedTarget));
+#if DCHECK_IS_ON()
+    DCHECK(relatedTarget);

[hayato, 2016/08/24 03:42:27]

You do not have to guard DCHECK(relataedTarget) by DCHECK_IS_ON.

+    DCHECK(!isUnreachableNode(*relatedTarget));
+#endif
     m_relatedTarget = relatedTarget;
 }
 
 inline bool TreeScopeEventContext::isInclusiveAncestorOf(const TreeScopeEventContext& other) const
 {
-    ASSERT(m_preOrder != -1 && m_postOrder != -1 && other.m_preOrder != -1 && other.m_postOrder != -1);
+    DCHECK_NE(m_preOrder, -1);
+    DCHECK_NE(m_postOrder, -1);
+    DCHECK_NE(other.m_preOrder, -1);
+    DCHECK_NE(other.m_postOrder, -1);
     return m_preOrder <= other.m_preOrder && other.m_postOrder <= m_postOrder;
 }
 
 inline bool TreeScopeEventContext::isDescendantOf(const TreeScopeEventContext& other) const
 {
-    ASSERT(m_preOrder != -1 && m_postOrder != -1 && other.m_preOrder != -1 && other.m_postOrder != -1);
+    DCHECK_NE(m_preOrder, -1);
+    DCHECK_NE(m_postOrder, -1);
+    DCHECK_NE(other.m_preOrder, -1);
+    DCHECK_NE(other.m_postOrder, -1);
     return other.m_preOrder < m_preOrder && m_postOrder < other.m_postOrder;
 }
 
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
 inline bool TreeScopeEventContext::isExclusivePartOf(const TreeScopeEventContext& other) const
 {
-    ASSERT(m_preOrder != -1 && m_postOrder != -1 && other.m_preOrder != -1 && other.m_postOrder != -1);
+    DCHECK_NE(m_preOrder, -1);
+    DCHECK_NE(m_postOrder, -1);
+    DCHECK_NE(other.m_preOrder, -1);
+    DCHECK_NE(other.m_postOrder, -1);
     return (m_preOrder < other.m_preOrder && m_postOrder < other.m_preOrder)
         || (m_preOrder > other.m_preOrder && m_preOrder > other.m_postOrder);
 }
 #endif
 
 } // namespace blink
 
 #endif // TreeScopeEventContext_h