Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp

Issue 2270293002: Replace ASSERT*() with DCHECK*() in core/events/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: isUnreachableNode -> checkReachableNode Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp
diff --git a/third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp b/third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp
index fa52b6ef2934a4cf3338d6cc1065a209143c4aa8..74baddf35dc40e4902f6008637bc7726af6f9fd5 100644
--- a/third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp
+++ b/third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp
@@ -86,11 +86,11 @@ bool DOMWindowEventQueue::enqueueEvent(Event* event)
if (m_isClosed)
return false;
- ASSERT(event->target());
+ DCHECK(event->target());
InspectorInstrumentation::asyncTaskScheduled(event->target()->getExecutionContext(), event->type(), event);
bool wasAdded = m_queuedEvents.add(event).isNewEntry;
- ASSERT_UNUSED(wasAdded, wasAdded); // It should not have already been in the list.
+ DCHECK(wasAdded); // It should not have already been in the list.
if (!m_pendingEventTimer->isActive())
m_pendingEventTimer->startOneShot(0, BLINK_FROM_HERE);
@@ -124,13 +124,13 @@ void DOMWindowEventQueue::close()
void DOMWindowEventQueue::pendingEventTimerFired()
{
- ASSERT(!m_pendingEventTimer->isActive());
- ASSERT(!m_queuedEvents.isEmpty());
+ DCHECK(!m_pendingEventTimer->isActive());
+ DCHECK(!m_queuedEvents.isEmpty());
// Insert a marker for where we should stop.
- ASSERT(!m_queuedEvents.contains(nullptr));
+ DCHECK(!m_queuedEvents.contains(nullptr));
bool wasAdded = m_queuedEvents.add(nullptr).isNewEntry;
- ASSERT_UNUSED(wasAdded, wasAdded); // It should not have already been in the list.
+ DCHECK(wasAdded); // It should not have already been in the list.
while (!m_queuedEvents.isEmpty()) {
HeapListHashSet<Member<Event>, 16>::iterator iter = m_queuedEvents.begin();

Powered by Google App Engine
This is Rietveld 408576698