third_party/WebKit/Source/core/events/EventTarget.cpp - Issue 2270293002: Replace ASSERT*() with DCHECK*() in core/events/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 2270293002: Replace ASSERT*() with DCHECK*() in core/events/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: isUnreachableNode -> checkReachableNode Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/events/EventTarget.cpp

diff --git a/third_party/WebKit/Source/core/events/EventTarget.cpp b/third_party/WebKit/Source/core/events/EventTarget.cpp

index b6196b5a5759518ddaad490125bcb550e619f540..d98bb138c288ff47c9a2f04c3a6e7e6343915351 100644

--- a/third_party/WebKit/Source/core/events/EventTarget.cpp

+++ b/third_party/WebKit/Source/core/events/EventTarget.cpp

@@ -510,7 +510,9 @@ void EventTarget::countLegacyEvents(const AtomicString& legacyTypeName, EventLis

DispatchEventResult EventTarget::fireEventListeners(Event* event)

{

- ASSERT(!EventDispatchForbiddenScope::isEventDispatchForbidden());

+#if DCHECK_IS_ON()

+ DCHECK(!EventDispatchForbiddenScope::isEventDispatchForbidden());

+#endif

DCHECK(event);

DCHECK(event->wasInitialized());

@@ -655,7 +657,7 @@ bool EventTarget::fireEventListeners(Event* event, EventTargetData* d, EventList

event->setHandlingPassive(false);

- RELEASE_ASSERT(i <= size);

+ CHECK_LE(i, size);

}

d->firingEventIterators->removeLast();

return firedListener;