third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp - Issue 2270293002: Replace ASSERT*() with DCHECK*() in core/events/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

Issue 2270293002: Replace ASSERT*() with DCHECK*() in core/events/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: isUnreachableNode -> checkReachableNode Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

diff --git a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

index 06d029598a2779cb06b87609d5fd300f8e45004a..8dd136eb1b8080b56f12bf40846bad5a6986f1bb 100644

--- a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

+++ b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

@@ -18,7 +18,7 @@ PromiseRejectionEvent::PromiseRejectionEvent(ScriptState* state, const AtomicStr

, m_scriptState(state)

{

ThreadState::current()->registerPreFinalizer(this);

- ASSERT(initializer.hasPromise());

+ DCHECK(initializer.hasPromise());

m_promise.set(initializer.promise().isolate(), initializer.promise().v8Value());

m_promise.setPhantom();

if (initializer.hasReason()) {