third_party/WebKit/Source/core/events/MessageEvent.cpp - Issue 2270293002: Replace ASSERT*() with DCHECK*() in core/events/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/MessageEvent.cpp

Issue 2270293002: Replace ASSERT*() with DCHECK*() in core/events/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: isUnreachableNode -> checkReachableNode Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/events/MessageEvent.h ('k') | third_party/WebKit/Source/core/events/NodeEventContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/MessageEvent.cpp

diff --git a/third_party/WebKit/Source/core/events/MessageEvent.cpp b/third_party/WebKit/Source/core/events/MessageEvent.cpp

index 0966e1708e7a01594559432b9410aa5ce5258064..42f3a544ab29806d7c70ff8eb10b28dd5baec1bc 100644

--- a/third_party/WebKit/Source/core/events/MessageEvent.cpp

+++ b/third_party/WebKit/Source/core/events/MessageEvent.cpp

@@ -60,7 +60,7 @@ MessageEvent::MessageEvent(const AtomicString& type, const MessageEventInit& ini

m_source = initializer.source();

if (initializer.hasPorts())

m_ports = new MessagePortArray(initializer.ports());

- ASSERT(isValidSource(m_source.get()));

+ DCHECK(isValidSource(m_source.get()));

}

MessageEvent::MessageEvent(const String& origin, const String& lastEventId, EventTarget* source, MessagePortArray* ports, const String& suborigin)

@@ -71,7 +71,7 @@ MessageEvent::MessageEvent(const String& origin, const String& lastEventId, Even

, m_source(source)

, m_ports(ports)

{

- ASSERT(isValidSource(m_source.get()));

+ DCHECK(isValidSource(m_source.get()));

}

MessageEvent::MessageEvent(PassRefPtr<SerializedScriptValue> data, const String& origin, const String& lastEventId, EventTarget* source, MessagePortArray* ports, const String& suborigin)

@@ -85,7 +85,7 @@ MessageEvent::MessageEvent(PassRefPtr<SerializedScriptValue> data, const String&

{

if (m_dataAsSerializedScriptValue)

m_dataAsSerializedScriptValue->registerMemoryAllocatedWithCurrentScriptContext();

- ASSERT(isValidSource(m_source.get()));

+ DCHECK(isValidSource(m_source.get()));

}

MessageEvent::MessageEvent(PassRefPtr<SerializedScriptValue> data, const String& origin, const String& lastEventId, EventTarget* source, std::unique_ptr<MessagePortChannelArray> channels, const String& suborigin)

@@ -100,7 +100,7 @@ MessageEvent::MessageEvent(PassRefPtr<SerializedScriptValue> data, const String&

{

if (m_dataAsSerializedScriptValue)

m_dataAsSerializedScriptValue->registerMemoryAllocatedWithCurrentScriptContext();

- ASSERT(isValidSource(m_source.get()));

+ DCHECK(isValidSource(m_source.get()));

}

MessageEvent::MessageEvent(const String& data, const String& origin, const String& suborigin)

« no previous file with comments | « third_party/WebKit/Source/core/events/MessageEvent.h ('k') | third_party/WebKit/Source/core/events/NodeEventContext.h » ('j') | no next file with comments »