Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots(). (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use NeedsContext() instead of comparing num_heap_slots(). R=verwaest@chromium.org, bmeurer@chromium.org BUG= Committed: https://crrev.com/4671660f106d245eba6e2fe49bed686f67df91a2 Cr-Commit-Position: refs/heads/master@{#38885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -41 lines) Patch
M src/compiler/ast-graph-builder.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
neis
4 years, 3 months ago (2016-08-24 16:53:49 UTC) #1
Benedikt Meurer
Nice. LGTM.
4 years, 3 months ago (2016-08-24 17:41:58 UTC) #2
Toon Verwaest
lgtm
4 years, 3 months ago (2016-08-24 18:03:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269403003/1
4 years, 3 months ago (2016-08-25 06:05:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 06:29:42 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 06:30:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4671660f106d245eba6e2fe49bed686f67df91a2
Cr-Commit-Position: refs/heads/master@{#38885}

Powered by Google App Engine
This is Rietveld 408576698