src/crankshaft/ia32/lithium-codegen-ia32.cc - Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/ia32/lithium-codegen-ia32.cc

Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/ia32/lithium-codegen-ia32.cc

diff --git a/src/crankshaft/ia32/lithium-codegen-ia32.cc b/src/crankshaft/ia32/lithium-codegen-ia32.cc

index 8233659ddbe22c8c4f603d6d6b80fe232e3cbb73..10f8e26244cef25d8bdde683a4d4e28f82406ad9 100644

--- a/src/crankshaft/ia32/lithium-codegen-ia32.cc

+++ b/src/crankshaft/ia32/lithium-codegen-ia32.cc

@@ -164,7 +164,7 @@ void LCodeGen::DoPrologue(LPrologue* instr) {

Comment(";;; Prologue begin");

// Possibly allocate a local context.

- if (info_->scope()->num_heap_slots() > 0) {

+ if (info_->scope()->NeedsContext()) {

Comment(";;; Allocate local context");

bool need_write_barrier = true;

// Argument to NewContext is the function, which is still in edi.

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/ia32/lithium-ia32.cc » ('j') | no next file with comments »