Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Side by Side Diff: src/crankshaft/ia32/lithium-codegen-ia32.cc

Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h" 7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 if (info()->saves_caller_doubles()) SaveCallerDoubles(); 157 if (info()->saves_caller_doubles()) SaveCallerDoubles();
158 } 158 }
159 return !is_aborted(); 159 return !is_aborted();
160 } 160 }
161 161
162 162
163 void LCodeGen::DoPrologue(LPrologue* instr) { 163 void LCodeGen::DoPrologue(LPrologue* instr) {
164 Comment(";;; Prologue begin"); 164 Comment(";;; Prologue begin");
165 165
166 // Possibly allocate a local context. 166 // Possibly allocate a local context.
167 if (info_->scope()->num_heap_slots() > 0) { 167 if (info_->scope()->NeedsContext()) {
168 Comment(";;; Allocate local context"); 168 Comment(";;; Allocate local context");
169 bool need_write_barrier = true; 169 bool need_write_barrier = true;
170 // Argument to NewContext is the function, which is still in edi. 170 // Argument to NewContext is the function, which is still in edi.
171 int slots = info_->scope()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS; 171 int slots = info_->scope()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
172 Safepoint::DeoptMode deopt_mode = Safepoint::kNoLazyDeopt; 172 Safepoint::DeoptMode deopt_mode = Safepoint::kNoLazyDeopt;
173 if (info()->scope()->is_script_scope()) { 173 if (info()->scope()->is_script_scope()) {
174 __ push(edi); 174 __ push(edi);
175 __ Push(info()->scope()->GetScopeInfo(info()->isolate())); 175 __ Push(info()->scope()->GetScopeInfo(info()->isolate()));
176 __ CallRuntime(Runtime::kNewScriptContext); 176 __ CallRuntime(Runtime::kNewScriptContext);
177 deopt_mode = Safepoint::kLazyDeopt; 177 deopt_mode = Safepoint::kLazyDeopt;
(...skipping 5103 matching lines...) Expand 10 before | Expand all | Expand 10 after
5281 __ bind(deferred->exit()); 5281 __ bind(deferred->exit());
5282 __ bind(&done); 5282 __ bind(&done);
5283 } 5283 }
5284 5284
5285 #undef __ 5285 #undef __
5286 5286
5287 } // namespace internal 5287 } // namespace internal
5288 } // namespace v8 5288 } // namespace v8
5289 5289
5290 #endif // V8_TARGET_ARCH_IA32 5290 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698