Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/s390/lithium-s390.cc ('k') | src/crankshaft/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/crankshaft/x64/lithium-codegen-x64.h" 7 #include "src/crankshaft/x64/lithium-codegen-x64.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 } 160 }
161 } 161 }
162 return !is_aborted(); 162 return !is_aborted();
163 } 163 }
164 164
165 165
166 void LCodeGen::DoPrologue(LPrologue* instr) { 166 void LCodeGen::DoPrologue(LPrologue* instr) {
167 Comment(";;; Prologue begin"); 167 Comment(";;; Prologue begin");
168 168
169 // Possibly allocate a local context. 169 // Possibly allocate a local context.
170 if (info_->scope()->num_heap_slots() > 0) { 170 if (info_->scope()->NeedsContext()) {
171 Comment(";;; Allocate local context"); 171 Comment(";;; Allocate local context");
172 bool need_write_barrier = true; 172 bool need_write_barrier = true;
173 // Argument to NewContext is the function, which is still in rdi. 173 // Argument to NewContext is the function, which is still in rdi.
174 int slots = info_->scope()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS; 174 int slots = info_->scope()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
175 Safepoint::DeoptMode deopt_mode = Safepoint::kNoLazyDeopt; 175 Safepoint::DeoptMode deopt_mode = Safepoint::kNoLazyDeopt;
176 if (info()->scope()->is_script_scope()) { 176 if (info()->scope()->is_script_scope()) {
177 __ Push(rdi); 177 __ Push(rdi);
178 __ Push(info()->scope()->GetScopeInfo(info()->isolate())); 178 __ Push(info()->scope()->GetScopeInfo(info()->isolate()));
179 __ CallRuntime(Runtime::kNewScriptContext); 179 __ CallRuntime(Runtime::kNewScriptContext);
180 deopt_mode = Safepoint::kLazyDeopt; 180 deopt_mode = Safepoint::kLazyDeopt;
(...skipping 5383 matching lines...) Expand 10 before | Expand all | Expand 10 after
5564 __ bind(deferred->exit()); 5564 __ bind(deferred->exit());
5565 __ bind(&done); 5565 __ bind(&done);
5566 } 5566 }
5567 5567
5568 #undef __ 5568 #undef __
5569 5569
5570 } // namespace internal 5570 } // namespace internal
5571 } // namespace v8 5571 } // namespace v8
5572 5572
5573 #endif // V8_TARGET_ARCH_X64 5573 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/crankshaft/s390/lithium-s390.cc ('k') | src/crankshaft/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698