src/crankshaft/ia32/lithium-ia32.cc - Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/ia32/lithium-ia32.cc

Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/ia32/lithium-ia32.cc

diff --git a/src/crankshaft/ia32/lithium-ia32.cc b/src/crankshaft/ia32/lithium-ia32.cc

index 67942241e6f1993557dec0ef28dd9806ddde7e53..5695826f62e9dfe7893d14692eb76d9b3d5130b6 100644

--- a/src/crankshaft/ia32/lithium-ia32.cc

+++ b/src/crankshaft/ia32/lithium-ia32.cc

@@ -910,7 +910,7 @@ void LChunkBuilder::AddInstruction(LInstruction* instr,

LInstruction* LChunkBuilder::DoPrologue(HPrologue* instr) {

LInstruction* result = new (zone()) LPrologue();

- if (info_->scope()->num_heap_slots() > 0) {

+ if (info_->scope()->NeedsContext()) {

result = MarkAsCall(result, instr);

}

return result;