Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Side by Side Diff: src/crankshaft/hydrogen.cc

Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen.h" 5 #include "src/crankshaft/hydrogen.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/allocation-site-scopes.h" 10 #include "src/allocation-site-scopes.h"
(...skipping 8381 matching lines...) Expand 10 before | Expand all | Expand 10 after
8392 target_shared->DisableOptimization(kParseScopeError); 8392 target_shared->DisableOptimization(kParseScopeError);
8393 } 8393 }
8394 TraceInline(target, caller, "parse failure"); 8394 TraceInline(target, caller, "parse failure");
8395 return false; 8395 return false;
8396 } 8396 }
8397 if (target_shared->dont_crankshaft()) { 8397 if (target_shared->dont_crankshaft()) {
8398 TraceInline(target, caller, "ParseAndAnalyze found incompatibility"); 8398 TraceInline(target, caller, "ParseAndAnalyze found incompatibility");
8399 return false; 8399 return false;
8400 } 8400 }
8401 8401
8402 if (target_info.scope()->num_heap_slots() > 0) { 8402 if (target_info.scope()->NeedsContext()) {
8403 TraceInline(target, caller, "target has context-allocated variables"); 8403 TraceInline(target, caller, "target has context-allocated variables");
8404 return false; 8404 return false;
8405 } 8405 }
8406 8406
8407 if (target_info.scope()->rest_parameter() != nullptr) { 8407 if (target_info.scope()->rest_parameter() != nullptr) {
8408 TraceInline(target, caller, "target uses rest parameters"); 8408 TraceInline(target, caller, "target uses rest parameters");
8409 return false; 8409 return false;
8410 } 8410 }
8411 8411
8412 FunctionLiteral* function = target_info.literal(); 8412 FunctionLiteral* function = target_info.literal();
(...skipping 5016 matching lines...) Expand 10 before | Expand all | Expand 10 after
13429 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13429 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13430 } 13430 }
13431 13431
13432 #ifdef DEBUG 13432 #ifdef DEBUG
13433 graph_->Verify(false); // No full verify. 13433 graph_->Verify(false); // No full verify.
13434 #endif 13434 #endif
13435 } 13435 }
13436 13436
13437 } // namespace internal 13437 } // namespace internal
13438 } // namespace v8 13438 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698