src/crankshaft/hydrogen.cc - Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2269403003: Use NeedsContext() instead of comparing num_heap_slots(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 95f2d7a153e885a20b6c954c565df4fc5dc792d5..cc8dc59042e431de4087afb6e50b924a7f941963 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -8399,7 +8399,7 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,

return false;

}

- if (target_info.scope()->num_heap_slots() > 0) {

+ if (target_info.scope()->NeedsContext()) {

TraceInline(target, caller, "target has context-allocated variables");

return false;

}