Remove implementation of Panels on OSes other than ChromeOS.

Remove implementation of Panels on OSes other than ChromeOS.

This affects Win, Mac and Linux. On those platforms, attempting to open a Panel via chrome.windows.open (...'panel'...) API will not fail (since there are still users of Hangouts extension out there) but degrade to a popup instead.

On ChromeOS, the 'regular' way of creating ChromeOS panels remains unaffectd (via chrome.app.window.create), while window.open continues to work as before (whitelisted for Hangouts, as before).

The flags 'enable-panels' and 'disable-panels' are gone as well, and panel tests are also removed.

The patch is big but it's mostly wholesale removal of panel-related directories, BUILD files changes and tests removal.

BUG=571511
Committed: https://crrev.com/566d3644fd8cee5e104139b3c6a6c1a857c8d2c4
Cr-Commit-Position: refs/heads/master@{#413759}

[Dmitry Titov, 2016-08-20 06:36:15]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 06:36:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 06:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 06:48:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dmitry Titov, 2016-08-20 07:48:44]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 07:48:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 08:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 08:00:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dmitry Titov, 2016-08-20 08:06:08]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 08:06:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 08:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 08:16:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dmitry Titov, 2016-08-20 08:22:29]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 08:22:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2016-08-20 08:35:00]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 08:35:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 08:49:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 08:49:23]

Dry run: Exceeded global retry quota

[Dmitry Titov, 2016-08-20 09:06:43]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 09:06:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 09:16:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 09:16:03]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Dmitry Titov, 2016-08-21 06:41:40]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-21 06:41:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 07:30:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-21 07:30:55]

Dry run: Exceeded global retry quota

[Dmitry Titov, 2016-08-21 08:15:08]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-21 08:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 08:28:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-21 08:28:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dmitry Titov, 2016-08-21 17:27:05]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-21 17:27:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 18:46:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-21 18:46:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dmitry Titov, 2016-08-21 19:11:32]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-21 19:11:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 19:24:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-21 19:24:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dmitry Titov, 2016-08-21 19:47:27]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-21 19:47:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2016-08-21 20:56:32]

Description was changed from

==========
Remove implementation of Panels on OSes other than ChromeOS.

BUG=571511
==========

to

==========
Remove implementation of Panels on OSes other than ChromeOS.

This affects Win, Mac and Linux. On those platforms, attempting to open a Panel
via chrome.windows.open (...'panel'...) API will not fail (since there are still
users of Hangouts extension out there) but degrade to a popup instead.

On ChromeOS, the 'regular' way of creating ChromeOS panels remains unaffectd
(via chrome.app.window.create), while window.open continues to work as before
(whitelisted for Hangouts, as before).

The flags 'enable-panels' and 'disable-panels' are gone as well, and panel tests
are also removed.

The patch is big but it's mostly wholesale removal of panel-related directories,
BUILD files changes and tests removal.

BUG=571511
==========

[commit-bot: I haz the power, 2016-08-21 21:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-21 21:06:31]

Dry run: This issue passed the CQ dry run.

[Dmitry Titov, 2016-08-21 21:06:36]

PTAL. It took a bit to get bits for all platforms green. While big, this patch
is mostly removal of a few entire directories that had panels code, tests and
updated build files. The only functional change is in tab_api.cc (open Popup
instead of Panel).

stevenjb: please look at tab_api.cc etc to see if this leaves ChromeOS as it
should.

sky: for OWNERS look.

[Dmitry Titov, 2016-08-21 21:07:32]

dimich@chromium.org changed reviewers:
+ sky@chromium.org, stevenjb@chromium.org

[Dmitry Titov, 2016-08-21 21:07:33]

Now with stevenjb and sky actually added.

[sky, 2016-08-22 15:05:55]

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:508: bool create_chromeOS_panel =
false;
Style guide says all lower case, e.g. chrome_os_panel, or perhaps
chromeos_panel.

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:597: #if defined(USE_ASH)
If you're setting chrome_os_panel to true based on a OS_CHROMEOS ifdef,
shouldn't this match? I'm asking why this isn't now OS_CHROMEOS too?

[stevenjb, 2016-08-22 15:45:03]

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:508: bool create_chromeOS_panel =
false;
On 2016/08/22 15:05:55, sky wrote:
> Style guide says all lower case, e.g. chrome_os_panel, or perhaps
> chromeos_panel.

create_ash_panel would be best (see below). Also the variable itself should be
ASH only.

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:543: window_type =
Browser::TYPE_POPUP;
Don't we need to set extension_id for non chrome os? I think this would be more
clear like:

case *_PANEL:
#if CHROMEOS
  if (IsHangoutExtension(extension()->id())) {
    create_cros_panel = true;
    break;
   }
#endif
   // On other platforms, treat panels like popups.
case POPUP:
   ...

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:597: #if defined(USE_ASH)
On 2016/08/22 15:05:55, sky wrote:
> If you're setting chrome_os_panel to true based on a OS_CHROMEOS ifdef,
> shouldn't this match? I'm asking why this isn't now OS_CHROMEOS too?

Agreed, we should be consistent. I think USE_ASH is more correct, even though
they are now synonymous.

Also, we should now put the entire if (create_ash_panel) inside the #if (and the
variable itself also).

[Dmitry Titov, 2016-08-22 23:45:04]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 23:45:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2016-08-22 23:45:54]

ptal

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:508: bool create_chromeOS_panel =
false;
On 2016/08/22 15:05:55, sky wrote:
> Style guide says all lower case, e.g. chrome_os_panel, or perhaps
> chromeos_panel.

Done.

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:508: bool create_chromeOS_panel =
false;
On 2016/08/22 15:45:02, stevenjb wrote:
> On 2016/08/22 15:05:55, sky wrote:
> > Style guide says all lower case, e.g. chrome_os_panel, or perhaps
> > chromeos_panel.
> 
> create_ash_panel would be best (see below). Also the variable itself should be
> ASH only.
> 

Done.

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:543: window_type =
Browser::TYPE_POPUP;
On 2016/08/22 15:45:02, stevenjb wrote:
> Don't we need to set extension_id for non chrome os? I think this would be
more
> clear like:
> 
> case *_PANEL:
> #if CHROMEOS
>   if (IsHangoutExtension(extension()->id())) {
>     create_cros_panel = true;
>     break;
>    }
> #endif
>    // On other platforms, treat panels like popups.
> case POPUP:
>    ...

Done.

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:597: #if defined(USE_ASH)
On 2016/08/22 15:05:55, sky wrote:
> If you're setting chrome_os_panel to true based on a OS_CHROMEOS ifdef,
> shouldn't this match? I'm asking why this isn't now OS_CHROMEOS too?

Done.

https://codereview.chromium.org/2263863002/diff/110001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_api.cc:597: #if defined(USE_ASH)
On 2016/08/22 15:45:02, stevenjb wrote:
> On 2016/08/22 15:05:55, sky wrote:
> > If you're setting chrome_os_panel to true based on a OS_CHROMEOS ifdef,
> > shouldn't this match? I'm asking why this isn't now OS_CHROMEOS too?
> 
> Agreed, we should be consistent. I think USE_ASH is more correct, even though
> they are now synonymous.
> 
> Also, we should now put the entire if (create_ash_panel) inside the #if (and
the
> variable itself also).

Done.

[commit-bot: I haz the power, 2016-08-23 01:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 01:22:29]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-23 13:17:55]

LGTM

[stevenjb, 2016-08-23 15:33:55]

lgtm

[Dmitry Titov, 2016-08-23 16:31:10]

The CQ bit was checked by dimich@chromium.org

[commit-bot: I haz the power, 2016-08-23 16:31:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 16:39:23]

Description was changed from

==========
Remove implementation of Panels on OSes other than ChromeOS.

This affects Win, Mac and Linux. On those platforms, attempting to open a Panel
via chrome.windows.open (...'panel'...) API will not fail (since there are still
users of Hangouts extension out there) but degrade to a popup instead.

On ChromeOS, the 'regular' way of creating ChromeOS panels remains unaffectd
(via chrome.app.window.create), while window.open continues to work as before
(whitelisted for Hangouts, as before).

The flags 'enable-panels' and 'disable-panels' are gone as well, and panel tests
are also removed.

The patch is big but it's mostly wholesale removal of panel-related directories,
BUILD files changes and tests removal.

BUG=571511
==========

to

==========
Remove implementation of Panels on OSes other than ChromeOS.

This affects Win, Mac and Linux. On those platforms, attempting to open a Panel
via chrome.windows.open (...'panel'...) API will not fail (since there are still
users of Hangouts extension out there) but degrade to a popup instead.

On ChromeOS, the 'regular' way of creating ChromeOS panels remains unaffectd
(via chrome.app.window.create), while window.open continues to work as before
(whitelisted for Hangouts, as before).

The flags 'enable-panels' and 'disable-panels' are gone as well, and panel tests
are also removed.

The patch is big but it's mostly wholesale removal of panel-related directories,
BUILD files changes and tests removal.

BUG=571511
==========

[commit-bot: I haz the power, 2016-08-23 16:39:25]

Committed patchset #13 (id:120001)

[commit-bot: I haz the power, 2016-08-23 16:41:29]

Description was changed from

==========
Remove implementation of Panels on OSes other than ChromeOS.

This affects Win, Mac and Linux. On those platforms, attempting to open a Panel
via chrome.windows.open (...'panel'...) API will not fail (since there are still
users of Hangouts extension out there) but degrade to a popup instead.

On ChromeOS, the 'regular' way of creating ChromeOS panels remains unaffectd
(via chrome.app.window.create), while window.open continues to work as before
(whitelisted for Hangouts, as before).

The flags 'enable-panels' and 'disable-panels' are gone as well, and panel tests
are also removed.

The patch is big but it's mostly wholesale removal of panel-related directories,
BUILD files changes and tests removal.

BUG=571511
==========

to

==========
Remove implementation of Panels on OSes other than ChromeOS.

This affects Win, Mac and Linux. On those platforms, attempting to open a Panel
via chrome.windows.open (...'panel'...) API will not fail (since there are still
users of Hangouts extension out there) but degrade to a popup instead.

On ChromeOS, the 'regular' way of creating ChromeOS panels remains unaffectd
(via chrome.app.window.create), while window.open continues to work as before
(whitelisted for Hangouts, as before).

The flags 'enable-panels' and 'disable-panels' are gone as well, and panel tests
are also removed.

The patch is big but it's mostly wholesale removal of panel-related directories,
BUILD files changes and tests removal.

BUG=571511

Committed: https://crrev.com/566d3644fd8cee5e104139b3c6a6c1a857c8d2c4
Cr-Commit-Position: refs/heads/master@{#413759}
==========

[commit-bot: I haz the power, 2016-08-23 16:41:33]

Patchset 13 (id:??) landed as
https://crrev.com/566d3644fd8cee5e104139b3c6a6c1a857c8d2c4
Cr-Commit-Position: refs/heads/master@{#413759}