Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/browser/task_manager/web_contents_tags.cc

Issue 2263863002: Remove implementation of Panels on OSes other than ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/web_contents_tags.h ('k') | chrome/browser/ui/cocoa/panels/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/web_contents_tags.cc
diff --git a/chrome/browser/task_manager/web_contents_tags.cc b/chrome/browser/task_manager/web_contents_tags.cc
index adb6eb4cb8a105bccdd4ed3d14287b039f745ef4..5a07d8b5db5750d44f99ea8b56786c9eb14495b3 100644
--- a/chrome/browser/task_manager/web_contents_tags.cc
+++ b/chrome/browser/task_manager/web_contents_tags.cc
@@ -8,7 +8,6 @@
#include "chrome/browser/task_manager/providers/web_contents/devtools_tag.h"
#include "chrome/browser/task_manager/providers/web_contents/extension_tag.h"
#include "chrome/browser/task_manager/providers/web_contents/guest_tag.h"
-#include "chrome/browser/task_manager/providers/web_contents/panel_tag.h"
#include "chrome/browser/task_manager/providers/web_contents/prerender_tag.h"
#include "chrome/browser/task_manager/providers/web_contents/printing_tag.h"
#include "chrome/browser/task_manager/providers/web_contents/tab_contents_tag.h"
@@ -18,7 +17,6 @@
#include "extensions/browser/view_type_utils.h"
#if defined(ENABLE_EXTENSIONS)
-#include "chrome/browser/ui/panels/panel.h"
#include "extensions/browser/process_manager.h"
#endif
@@ -51,8 +49,7 @@ bool IsExtensionWebContents(content::WebContents* contents) {
extensions::ViewType view_type = extensions::GetViewType(contents);
return (view_type != extensions::VIEW_TYPE_INVALID &&
view_type != extensions::VIEW_TYPE_TAB_CONTENTS &&
- view_type != extensions::VIEW_TYPE_BACKGROUND_CONTENTS &&
- view_type != extensions::VIEW_TYPE_PANEL);
+ view_type != extensions::VIEW_TYPE_BACKGROUND_CONTENTS);
}
#endif // defined(ENABLE_EXTENSIONS)
@@ -110,21 +107,6 @@ void WebContentsTags::CreateForTabContents(content::WebContents* web_contents) {
}
// static
-void WebContentsTags::CreateForPanel(content::WebContents* web_contents,
- Panel* panel) {
-#if defined(ENABLE_TASK_MANAGER) && defined(ENABLE_EXTENSIONS)
- DCHECK(panel);
- DCHECK_EQ(web_contents, panel->GetWebContents());
-
- if (!WebContentsTag::FromWebContents(web_contents)) {
- TagWebContents(web_contents,
- new PanelTag(web_contents, panel),
- WebContentsTag::kTagKey);
- }
-#endif // defined(ENABLE_TASK_MANAGER) && defined(ENABLE_EXTENSIONS)
-}
-
-// static
void WebContentsTags::CreateForPrintingContents(
content::WebContents* web_contents) {
#if defined(ENABLE_TASK_MANAGER) && defined(ENABLE_PRINT_PREVIEW)
« no previous file with comments | « chrome/browser/task_manager/web_contents_tags.h ('k') | chrome/browser/ui/cocoa/panels/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698