Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3496)

Unified Diff: chrome/test/data/extensions/api_test/window_open/panel_browsing_instance/panel-subframe.js

Issue 2263863002: Remove implementation of Panels on OSes other than ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/window_open/panel_browsing_instance/panel-subframe.js
diff --git a/chrome/test/data/extensions/api_test/window_open/panel_browsing_instance/panel-subframe.js b/chrome/test/data/extensions/api_test/window_open/panel_browsing_instance/panel-subframe.js
deleted file mode 100644
index 8f897c9e6d6ff578443bd121fb596883ae1a4231..0000000000000000000000000000000000000000
--- a/chrome/test/data/extensions/api_test/window_open/panel_browsing_instance/panel-subframe.js
+++ /dev/null
@@ -1,27 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// If panel-subframe is (expectedly) in the same BrowsingInstance as
-// background-subframe, then window.open should find the existing iframe.
-//
-// Otherwise window.open will cause a new tab to be opened and we will
-// find this out and fail the test when comparing newNumberOfTabs and
-// oldNumberOfTabs in background.js.
-//
-// Note that we can't verify if |w| is a new window by looking
-// at |w.parent|, because this leads to an error similar to:
-// Uncaught SecurityError: Blocked a frame with origin "http://foo.com:36559"
-// from accessing a frame with origin
-// "chrome-extension://jmanjdlcdjhgbdccaamcmmcilljchoad". The frame
-// requesting access has a protocol of "http", the frame being accessed has a
-// protocol of "chrome-extension". Protocols must match.
-var w = window.open('http://blah', 'background-subframe-name')
-
-// Quick and very dirty query parameters parsing... ok only for test code.
-extensionId = window.location.href.substr(
- window.location.href.lastIndexOf('=') + 1);
-
-// Let background.js know that it can now calculate newNumberOfTabs.
-chrome.runtime.sendMessage(extensionId, { windowOpened: true });
-

Powered by Google App Engine
This is Rietveld 408576698