Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map. (Closed)

Created:
4 years, 4 months ago by benjhayden
Modified:
4 years, 3 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 : . #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fix longTasksMetric and Composition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -158 lines) Patch
M tracing/tracing/metrics/cpu_process_metric.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/loading_metric.html View 1 2 3 chunks +7 lines, -12 lines 0 comments Download
M tracing/tracing/metrics/system_health/long_tasks_metric.html View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/system_health/responsiveness_metric.html View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/tracing_metric.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/value/diagnostics/composition.html View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M tracing/tracing/value/diagnostics/diagnostic_map.html View 1 2 3 4 1 chunk +24 lines, -53 lines 0 comments Download
M tracing/tracing/value/diagnostics/iteration_info.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/histogram_test.html View 1 4 chunks +21 lines, -21 lines 0 comments Download
M tracing/tracing/value/ui/diagnostic_map_table.html View 1 2 chunks +4 lines, -6 lines 0 comments Download
M tracing/tracing/value/ui/diagnostic_map_table_test.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tracing/tracing/value/ui/histogram_span_test.html View 1 2 chunks +15 lines, -13 lines 0 comments Download
M tracing/tracing/value/ui/value_set_table.html View 1 2 3 1 chunk +8 lines, -4 lines 0 comments Download
M tracing/tracing/value/value_set.html View 1 2 3 6 chunks +25 lines, -24 lines 0 comments Download
M tracing/tracing/value/value_set_test.html View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M tracing/tracing/value/value_test.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 40 (23 generated)
benjhayden
PTAL :-)
4 years, 4 months ago (2016-08-19 00:26:58 UTC) #5
benjhayden
ping?
4 years, 3 months ago (2016-08-24 18:53:36 UTC) #6
eakuefner
lgtm
4 years, 3 months ago (2016-08-24 19:04:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258583003/70001
4 years, 3 months ago (2016-08-24 21:02:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_TIMED_OUT, no build URL) ...
4 years, 3 months ago (2016-08-24 23:02:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258583003/70001
4 years, 3 months ago (2016-08-24 23:25:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/4416)
4 years, 3 months ago (2016-08-25 01:39:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258583003/70001
4 years, 3 months ago (2016-08-25 19:07:10 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/4428)
4 years, 3 months ago (2016-08-25 19:31:41 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258583003/90001
4 years, 3 months ago (2016-08-26 05:00:23 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Mac%20Tryserver/builds/4622)
4 years, 3 months ago (2016-08-26 05:07:50 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258583003/90001
4 years, 3 months ago (2016-08-26 05:23:50 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/4452)
4 years, 3 months ago (2016-08-26 05:25:45 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258583003/110001
4 years, 3 months ago (2016-08-26 05:41:00 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Mac%20Tryserver/builds/4628)
4 years, 3 months ago (2016-08-26 05:56:26 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258583003/130001
4 years, 3 months ago (2016-08-26 17:08:04 UTC) #38
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:30:44 UTC) #40
Message was sent while issue was closed. 
Committed patchset #5 (id:130001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698