Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: tracing/tracing/metrics/tracing_metric.html

Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: fix longTasksMetric and Composition Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/tracing_metric.html
diff --git a/tracing/tracing/metrics/tracing_metric.html b/tracing/tracing/metrics/tracing_metric.html
index b6a0ef03ffa59cba8f4af4048638c50f23a55d77..3b6cbb4ea868032617d8af9eb173d388baf88d0e 100644
--- a/tracing/tracing/metrics/tracing_metric.html
+++ b/tracing/tracing/metrics/tracing_metric.html
@@ -165,19 +165,19 @@ tr.exportTo('tr.metrics', function() {
var totalBytes = new tr.v.NumericValue(
'Total trace size in bytes', totalTraceBytesValue);
- totalBytes.diagnostics.add(
+ totalBytes.diagnostics.set(
'category_with_max_event_size', new tr.v.d.Generic(biggestCategory));
values.addValue(totalBytes);
var peakEvents = new tr.v.NumericValue(
'Max number of events per second', maxEventCountPerSecValue);
- peakEvents.diagnostics.add(
+ peakEvents.diagnostics.set(
'category_with_max_event_size', new tr.v.d.Generic(biggestCategory));
values.addValue(peakEvents);
var peakBytes = new tr.v.NumericValue(
'Max event size in bytes per second', maxEventBytesPerSecValue);
- peakBytes.diagnostics.add(
+ peakBytes.diagnostics.set(
'category_with_max_event_size', new tr.v.d.Generic(biggestCategory));
values.addValue(peakBytes);
« no previous file with comments | « tracing/tracing/metrics/system_health/responsiveness_metric.html ('k') | tracing/tracing/value/diagnostics/composition.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698