tracing/tracing/value/ui/diagnostic_map_table_test.html - Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/value/ui/diagnostic_map_table_test.html

Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: fix longTasksMetric and Composition Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/value/ui/diagnostic_map_table_test.html

diff --git a/tracing/tracing/value/ui/diagnostic_map_table_test.html b/tracing/tracing/value/ui/diagnostic_map_table_test.html

index a3896a2d7f0b51aba549d83f179dc7c4e0e25546..ac051aaeda5e31cf9f0ed6015a7fa5883c76b502 100644

--- a/tracing/tracing/value/ui/diagnostic_map_table_test.html

+++ b/tracing/tracing/value/ui/diagnostic_map_table_test.html

@@ -14,11 +14,11 @@ found in the LICENSE file.

tr.b.unittest.testSuite(function() {

test('instantiate', function() {

var map0 = new tr.v.d.DiagnosticMap();

- map0.add('genericA', new tr.v.d.Generic({a: 0}));

- map0.add('genericB', new tr.v.d.Generic({b: 0}));

+ map0.set('genericA', new tr.v.d.Generic({a: 0}));

+ map0.set('genericB', new tr.v.d.Generic({b: 0}));

var map1 = new tr.v.d.DiagnosticMap();

- map1.add('genericA', new tr.v.d.Generic({a: 1}));

- map1.add('genericB', new tr.v.d.Generic({b: 1}));

+ map1.set('genericA', new tr.v.d.Generic({a: 1}));

+ map1.set('genericB', new tr.v.d.Generic({b: 1}));

var table = document.createElement('tr-v-ui-diagnostic-map-table');

table.diagnosticMaps = [map0, map1];

this.addHTMLOutput(table);