tracing/tracing/metrics/system_health/responsiveness_metric.html - Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/responsiveness_metric.html

Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: fix longTasksMetric and Composition Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/metrics/system_health/responsiveness_metric.html

diff --git a/tracing/tracing/metrics/system_health/responsiveness_metric.html b/tracing/tracing/metrics/system_health/responsiveness_metric.html

index faef42ffc0ecb660120785bb148211901414f624..36d336ec1435ae7eaae68cf01f0d23b80ada4fc4 100644

--- a/tracing/tracing/metrics/system_health/responsiveness_metric.html

+++ b/tracing/tracing/metrics/system_health/responsiveness_metric.html

@@ -91,9 +91,8 @@ tr.exportTo('tr.metrics.sh', function() {

ue.start, ue.end))

return;

- var sampleDiagnostic = new tr.v.d.RelatedEventSet([ue]);

- var sampleDiagnosticMap =

- new tr.v.d.DiagnosticMap({relatedEvents: sampleDiagnostic});

+ var sampleDiagnosticMap = tr.v.d.DiagnosticMap.fromObject(

+ {relatedEvents: new tr.v.d.RelatedEventSet([ue])});

// Responsiveness is not defined for Idle or Startup expectations.

if (ue instanceof tr.model.um.IdleExpectation) {