Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: tracing/tracing/value/value_set_test.html

Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: fix longTasksMetric and Composition Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/value_set.html ('k') | tracing/tracing/value/value_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/value_set_test.html
diff --git a/tracing/tracing/value/value_set_test.html b/tracing/tracing/value/value_set_test.html
index 36b41aee295ebecaf1ffee6038d84cd9b42017b3..d76ed1debf80fbe88738d63e9cfa64d397251702 100644
--- a/tracing/tracing/value/value_set_test.html
+++ b/tracing/tracing/value/value_set_test.html
@@ -77,7 +77,7 @@ tr.b.unittest.testSuite(function() {
var a = new tr.v.NumericValue('a', new tr.v.ScalarNumeric(unit, 0));
var b = new tr.v.NumericValue('b', new tr.v.ScalarNumeric(unit, 1));
var c = new tr.v.NumericValue('c', new tr.v.ScalarNumeric(unit, 2));
- a.diagnostics.add('rvs', new tr.v.d.RelatedValueSet([b, c]));
+ a.diagnostics.set('rvs', new tr.v.d.RelatedValueSet([b, c]));
// Don't serialize c just yet.
var values = new tr.v.ValueSet([a, b]);
@@ -145,7 +145,7 @@ tr.b.unittest.testSuite(function() {
var rvm = new tr.v.d.RelatedValueMap();
rvm.set('y', b);
rvm.set('z', c);
- a.diagnostics.add('rvm', rvm);
+ a.diagnostics.set('rvm', rvm);
// Don't serialize c just yet.
var values = new tr.v.ValueSet([a, b]);
@@ -206,9 +206,8 @@ tr.b.unittest.testSuite(function() {
var numeric = tr.v.NumericBuilder.createLinear(
tr.v.Unit.byName.timeDurationInMs,
tr.b.Range.fromExplicitRange(0, 1000), 10).build();
- numeric.add(1, new tr.v.d.DiagnosticMap({
- rvs: new tr.v.d.RelatedValueSet([a])
- }));
+ numeric.add(1, tr.v.d.DiagnosticMap.fromObject({
+ rvs: new tr.v.d.RelatedValueSet([a])}));
var b = new tr.v.NumericValue('b', numeric);
var values = new tr.v.ValueSet([a, b]);
« no previous file with comments | « tracing/tracing/value/value_set.html ('k') | tracing/tracing/value/value_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698