tracing/tracing/value/diagnostics/composition.html - Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/value/diagnostics/composition.html

Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: fix longTasksMetric and Composition Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/value/diagnostics/composition.html

diff --git a/tracing/tracing/value/diagnostics/composition.html b/tracing/tracing/value/diagnostics/composition.html

index 3e8b59084cd1b8485aac474686cad5da441ba4ee..1c88c3716ba42ce7900d9159acb50aa49d0e1b48 100644

--- a/tracing/tracing/value/diagnostics/composition.html

+++ b/tracing/tracing/value/diagnostics/composition.html

@@ -108,10 +108,8 @@ tr.exportTo('tr.v.d', function() {

composition.set(eventCategory, value);

}

- value.numeric.add(

- sample,

- new tr.v.d.DiagnosticMap(

- {relatedEvents: new tr.v.d.RelatedEventSet([event])}));

+ value.numeric.add(sample, tr.v.d.DiagnosticMap.fromObject(

+ {relatedEvents: new tr.v.d.RelatedEventSet([event])}));

}

return composition;

}