Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: tracing/tracing/metrics/system_health/loading_metric.html

Issue 2258583003: Modernize DiagnosticMap to subclass ES6 Map. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: fix longTasksMetric and Composition Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/loading_metric.html
diff --git a/tracing/tracing/metrics/system_health/loading_metric.html b/tracing/tracing/metrics/system_health/loading_metric.html
index de31d8099e66b5f6a74006a944712b556cb4559e..5c00041610bad8298abcf5883c3838defe906411 100644
--- a/tracing/tracing/metrics/system_health/loading_metric.html
+++ b/tracing/tracing/metrics/system_health/loading_metric.html
@@ -280,14 +280,11 @@ tr.exportTo('tr.metrics.sh', function() {
continue;
var timeToEvent = ev.start - navigationStartEvent.start;
- histogram.add(
- timeToEvent,
- new tr.v.d.DiagnosticMap(
- {url: new tr.v.d.Generic(url)}));
+ histogram.add(timeToEvent, tr.v.d.DiagnosticMap.fromObject(
+ {url: new tr.v.d.Generic(url)}));
}
- values.addValue(new tr.v.NumericValue(
- metric.valueName, histogram,
- { description: metric.description }));
+ values.addValue(new tr.v.NumericValue(metric.valueName, histogram,
+ {description: metric.description}));
}
}
@@ -359,10 +356,8 @@ tr.exportTo('tr.metrics.sh', function() {
diagnosticDict.interactive = firstInteractive;
diagnosticDict.pid = rendererHelper.pid;
var timeToFirstInteractive = firstInteractive - navigationStartTime;
- histogram.add(
- timeToFirstInteractive,
- new tr.v.d.DiagnosticMap(
- {breakdown: new tr.v.d.Generic(diagnosticDict)}));
+ histogram.add(timeToFirstInteractive, tr.v.d.DiagnosticMap.fromObject(
+ {breakdown: new tr.v.d.Generic(diagnosticDict)}));
}
/**
@@ -417,7 +412,7 @@ tr.exportTo('tr.metrics.sh', function() {
diagnosticDict.url = url;
firstMeaningfulPaintHistogram.add(
timeToFirstMeaningfulPaint,
- new tr.v.d.DiagnosticMap(
+ tr.v.d.DiagnosticMap.fromObject(
{breakdown: new tr.v.d.Generic(diagnosticDict)}));
return {firstMeaningfulPaint: paintEvent.start, url: url};
}
« no previous file with comments | « tracing/tracing/metrics/cpu_process_metric.html ('k') | tracing/tracing/metrics/system_health/long_tasks_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698