Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2258263002: Consistently use namespaced base::Version. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, oshima+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, asvitkine+watch_chromium.org, davemoore+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistently use namespaced base::Version. BUG=639416 Committed: https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42 Cr-Commit-Position: refs/heads/master@{#415485}

Patch Set 1 #

Patch Set 2 : Rebased against master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -39 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/crl_set_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M components/variations/processed_study.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/variations/study_filtering_unittest.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M ios/chrome/browser/net/crl_set_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
pwnall
Can you please take a look? This is a pretty mechanic CL. FWIW, this is ...
4 years, 4 months ago (2016-08-19 20:38:43 UTC) #4
pwnall
Can you please take a look? This is a pretty mechanic CL. FWIW, this is ...
4 years, 4 months ago (2016-08-19 20:38:44 UTC) #5
pwnall
Can you please take a look at this CL too, Brett? It's the last piece ...
4 years, 3 months ago (2016-08-26 20:29:01 UTC) #11
brettw
lgtm
4 years, 3 months ago (2016-08-30 21:35:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258263002/1
4 years, 3 months ago (2016-08-30 21:36:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/61046) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-08-30 21:38:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258263002/40001
4 years, 3 months ago (2016-08-30 22:00:36 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-08-30 23:17:42 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 23:19:36 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42
Cr-Commit-Position: refs/heads/master@{#415485}

Powered by Google App Engine
This is Rietveld 408576698