chrome/browser/chrome_browser_main_win.cc - Issue 2258263002: Consistently use namespaced base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 2258263002: Consistently use namespaced base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased against master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_browser_main_win.cc

diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc

index a87834b8cac4e210ce0221f5ff5c89cebede0ad3..49142fb0dc98ec9e5f806ca76c1f97386f852a66 100644

--- a/chrome/browser/chrome_browser_main_win.cc

+++ b/chrome/browser/chrome_browser_main_win.cc

@@ -457,7 +457,7 @@ bool ChromeBrowserMainPartsWin::CheckMachineLevelInstall() {

// TODO(tommi): Check if using the default distribution is always the right

// thing to do.

BrowserDistribution* dist = BrowserDistribution::GetDistribution();

- Version version;

+ base::Version version;

InstallUtil::GetChromeVersion(dist, true, &version);

if (version.IsValid()) {

base::FilePath exe_path;

« no previous file with comments | « no previous file | chrome/browser/chromeos/app_mode/startup_app_launcher.cc » ('j') | no next file with comments »