Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: components/variations/study_filtering_unittest.cc

Issue 2258263002: Consistently use namespaced base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased against master. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/processed_study.cc ('k') | ios/chrome/browser/net/crl_set_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/study_filtering_unittest.cc
diff --git a/components/variations/study_filtering_unittest.cc b/components/variations/study_filtering_unittest.cc
index 0715432a5836795761fe0b5b663cd31a06b50416..0c9dfa06e358860778445a887efa284da099c315 100644
--- a/components/variations/study_filtering_unittest.cc
+++ b/components/variations/study_filtering_unittest.cc
@@ -280,8 +280,8 @@ TEST(VariationsStudyFilteringTest, CheckStudyVersion) {
for (size_t i = 0; i < arraysize(min_test_cases); ++i) {
filter.set_min_version(min_test_cases[i].min_version);
- const bool result =
- internal::CheckStudyVersion(filter, Version(min_test_cases[i].version));
+ const bool result = internal::CheckStudyVersion(
+ filter, base::Version(min_test_cases[i].version));
EXPECT_EQ(min_test_cases[i].expected_result, result) <<
"Min. version case " << i << " failed!";
}
@@ -289,8 +289,8 @@ TEST(VariationsStudyFilteringTest, CheckStudyVersion) {
for (size_t i = 0; i < arraysize(max_test_cases); ++i) {
filter.set_max_version(max_test_cases[i].max_version);
- const bool result =
- internal::CheckStudyVersion(filter, Version(max_test_cases[i].version));
+ const bool result = internal::CheckStudyVersion(
+ filter, base::Version(max_test_cases[i].version));
EXPECT_EQ(max_test_cases[i].expected_result, result) <<
"Max version case " << i << " failed!";
}
@@ -302,16 +302,14 @@ TEST(VariationsStudyFilteringTest, CheckStudyVersion) {
filter.set_max_version(max_test_cases[j].max_version);
if (!min_test_cases[i].expected_result) {
- const bool result =
- internal::CheckStudyVersion(
- filter, Version(min_test_cases[i].version));
+ const bool result = internal::CheckStudyVersion(
+ filter, base::Version(min_test_cases[i].version));
EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!";
}
if (!max_test_cases[j].expected_result) {
- const bool result =
- internal::CheckStudyVersion(
- filter, Version(max_test_cases[j].version));
+ const bool result = internal::CheckStudyVersion(
+ filter, base::Version(max_test_cases[j].version));
EXPECT_FALSE(result) << "Case " << i << "," << j << " failed!";
}
}
« no previous file with comments | « components/variations/processed_study.cc ('k') | ios/chrome/browser/net/crl_set_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698