chrome/browser/net/crl_set_fetcher.cc - Issue 2258263002: Consistently use namespaced base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/crl_set_fetcher.cc

Issue 2258263002: Consistently use namespaced base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased against master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/crl_set_fetcher.cc

diff --git a/chrome/browser/net/crl_set_fetcher.cc b/chrome/browser/net/crl_set_fetcher.cc

index c1a0efcc186bb20eb8ef4b7273884eda46bbc9ab..ef94c014412505405b58d8d5c29a459353720625 100644

--- a/chrome/browser/net/crl_set_fetcher.cc

+++ b/chrome/browser/net/crl_set_fetcher.cc

@@ -144,12 +144,12 @@ void CRLSetFetcher::RegisterComponent(uint32_t sequence_of_loaded_crl) {

kPublicKeySHA256 + sizeof(kPublicKeySHA256));

component.installer = this;

component.name = "CRLSet";

- component.version = Version(base::UintToString(sequence_of_loaded_crl));

+ component.version = base::Version(base::UintToString(sequence_of_loaded_crl));

component.allows_background_download = false;

component.requires_network_encryption = false;

if (!component.version.IsValid()) {

NOTREACHED();

- component.version = Version("0");

+ component.version = base::Version("0");

}

if (!cus_->RegisterComponent(component))