components/variations/processed_study.cc - Issue 2258263002: Consistently use namespaced base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/processed_study.cc

Issue 2258263002: Consistently use namespaced base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased against master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/variations/processed_study.cc

diff --git a/components/variations/processed_study.cc b/components/variations/processed_study.cc

index 8bf91e3b3ff0664a44f80a609b75e05cf5a1deca..8c1f8d0f8a1cd6852cd2fb234dbec9267b4f8710 100644

--- a/components/variations/processed_study.cc

+++ b/components/variations/processed_study.cc

@@ -27,13 +27,13 @@ bool ValidateStudyAndComputeTotalProbability(

return false;

}

if (study.filter().has_min_version() &&

- !Version::IsValidWildcardString(study.filter().min_version())) {

+ !base::Version::IsValidWildcardString(study.filter().min_version())) {

DVLOG(1) << study.name() << " has invalid min version: "

<< study.filter().min_version();

return false;

}

if (study.filter().has_max_version() &&

- !Version::IsValidWildcardString(study.filter().max_version())) {

+ !base::Version::IsValidWildcardString(study.filter().max_version())) {

DVLOG(1) << study.name() << " has invalid max version: "

<< study.filter().max_version();

return false;