chrome/browser/chromeos/app_mode/startup_app_launcher.cc - Issue 2258263002: Consistently use namespaced base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/app_mode/startup_app_launcher.cc

Issue 2258263002: Consistently use namespaced base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased against master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/app_mode/startup_app_launcher.cc

diff --git a/chrome/browser/chromeos/app_mode/startup_app_launcher.cc b/chrome/browser/chromeos/app_mode/startup_app_launcher.cc

index fa1ee128154b3f0f48d224a899137eb5625e3fba..00be024bd70a1d529a662e73061508d5425f23d6 100644

--- a/chrome/browser/chromeos/app_mode/startup_app_launcher.cc

+++ b/chrome/browser/chromeos/app_mode/startup_app_launcher.cc

@@ -312,9 +312,10 @@ void StartupAppLauncher::Observe(int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

DCHECK_EQ(extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND, type);

- using UpdateDetails = const std::pair<std::string, Version>;

+ using UpdateDetails = const std::pair<std::string, base::Version>;

const std::string& id = content::Details<UpdateDetails>(details)->first;

- const Version& version = content::Details<UpdateDetails>(details)->second;

+ const base::Version& version =

+ content::Details<UpdateDetails>(details)->second;

VLOG(1) << "Found extension update id=" << id

<< " version=" << version.GetString();

extension_update_found_ = true;