chrome/browser/profiles/profile_impl.cc - Issue 2258263002: Consistently use namespaced base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_impl.cc

Issue 2258263002: Consistently use namespaced base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased against master. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/profiles/profile_impl.cc

diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc

index 3bf337549f30ebab87fe90928b034440d062a29b..eb3077806a2ebb5e7d12ad227e4d48542848a26e 100644

--- a/chrome/browser/profiles/profile_impl.cc

+++ b/chrome/browser/profiles/profile_impl.cc

@@ -871,8 +871,8 @@ void ProfileImpl::OnPrefsLoaded(CreateMode create_mode, bool success) {

}

bool ProfileImpl::WasCreatedByVersionOrLater(const std::string& version) {

- Version profile_version(ChromeVersionService::GetVersion(prefs_.get()));

- Version arg_version(version);

+ base::Version profile_version(ChromeVersionService::GetVersion(prefs_.get()));

+ base::Version arg_version(version);

return (profile_version.CompareTo(arg_version) >= 0);

}