net/quic/core/reliable_quic_stream_test.cc - Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/reliable_quic_stream_test.cc

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/core/reliable_quic_stream_test.cc

diff --git a/net/quic/core/reliable_quic_stream_test.cc b/net/quic/core/reliable_quic_stream_test.cc

index 15e09cbdeef3557bfd623bffbbc33f010b6cf17d..ceeee843738bdb8c3fdec4f04d8f952efdb79a9a 100644

--- a/net/quic/core/reliable_quic_stream_test.cc

+++ b/net/quic/core/reliable_quic_stream_test.cc

@@ -184,7 +184,8 @@ TEST_F(ReliableQuicStreamTest, NoBlockingIfNoDataOrFin) {

// Write no data and no fin. If we consume nothing we should not be write

// blocked.

- EXPECT_DFATAL(stream_->WriteOrBufferData(StringPiece(), false, nullptr), "");

+ EXPECT_QUIC_BUG(stream_->WriteOrBufferData(StringPiece(), false, nullptr),

+ "");

EXPECT_FALSE(HasWriteBlockedStreams());

}

« no previous file with comments | « net/quic/core/quic_stream_sequencer_test.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »