Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: net/quic/core/quic_packet_generator_test.cc

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_packet_creator_test.cc ('k') | net/quic/core/quic_server_session_base_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_packet_generator_test.cc
diff --git a/net/quic/core/quic_packet_generator_test.cc b/net/quic/core/quic_packet_generator_test.cc
index f3a23273a03ed7e3d5b754ba1aa9e50f0e84cba1..56928b99f5929587170b2c90c88b7e4005f2e548 100644
--- a/net/quic/core/quic_packet_generator_test.cc
+++ b/net/quic/core/quic_packet_generator_test.cc
@@ -401,9 +401,9 @@ TEST_F(QuicPacketGeneratorTest, ConsumeData_Handshake) {
}
TEST_F(QuicPacketGeneratorTest, ConsumeData_EmptyData) {
- EXPECT_DFATAL(generator_.ConsumeData(kHeadersStreamId, MakeIOVector(""), 0,
- false, nullptr),
- "Attempt to consume empty data without FIN.");
+ EXPECT_QUIC_BUG(generator_.ConsumeData(kHeadersStreamId, MakeIOVector(""), 0,
+ false, nullptr),
+ "Attempt to consume empty data without FIN.");
}
TEST_F(QuicPacketGeneratorTest,
@@ -842,9 +842,9 @@ TEST_F(QuicPacketGeneratorTest, DontCrashOnInvalidStopWaiting) {
EXPECT_CALL(delegate_,
OnUnrecoverableError(QUIC_FAILED_TO_SERIALIZE_PACKET, _,
ConnectionCloseSource::FROM_SELF));
- EXPECT_DFATAL(generator_.FinishBatchOperations(),
- "packet_number_length 1 is too small "
- "for least_unacked_delta: 1001");
+ EXPECT_QUIC_BUG(generator_.FinishBatchOperations(),
+ "packet_number_length 1 is too small "
+ "for least_unacked_delta: 1001");
}
TEST_F(QuicPacketGeneratorTest, SetCurrentPath) {
@@ -863,8 +863,8 @@ TEST_F(QuicPacketGeneratorTest, SetCurrentPath) {
// Try to switch path when a packet is under construction.
QuicPathId kTestPathId1 = 1;
- EXPECT_DFATAL(generator_.SetCurrentPath(kTestPathId1, 1, 0),
- "Unable to change paths when a packet is under construction");
+ EXPECT_QUIC_BUG(generator_.SetCurrentPath(kTestPathId1, 1, 0),
+ "Unable to change paths when a packet is under construction");
EXPECT_EQ(kDefaultPathId, QuicPacketCreatorPeer::GetCurrentPath(creator_));
// Try to switch path after current open packet gets serialized.
« no previous file with comments | « net/quic/core/quic_packet_creator_test.cc ('k') | net/quic/core/quic_server_session_base_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698