Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: net/quic/core/quic_headers_stream_test.cc

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_framer_test.cc ('k') | net/quic/core/quic_multipath_received_packet_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_headers_stream_test.cc
diff --git a/net/quic/core/quic_headers_stream_test.cc b/net/quic/core/quic_headers_stream_test.cc
index 59f300e044ebae0e41cd8681c36366b188ef02ff..ba6e34b711076c715e230ed56a1978954f8e30d5 100644
--- a/net/quic/core/quic_headers_stream_test.cc
+++ b/net/quic/core/quic_headers_stream_test.cc
@@ -208,7 +208,6 @@ struct TestParams {
FLAGS_spdy_framer_use_new_methods3 = true;
break;
}
- FLAGS_quic_always_log_bugs_for_tests = true;
VLOG(1) << "TestParams: version: " << QuicVersionToString(version)
<< ", perspective: " << perspective
<< ", http2_decoder: " << http2_decoder
@@ -460,7 +459,7 @@ TEST_P(QuicHeadersStreamTest, WritePushPromises) {
CheckHeaders();
saved_data_.clear();
} else {
- EXPECT_DFATAL(
+ EXPECT_QUIC_BUG(
headers_stream_->WritePushPromise(stream_id, promised_stream_id,
headers_.Clone(), nullptr),
"Client shouldn't send PUSH_PROMISE");
« no previous file with comments | « net/quic/core/quic_framer_test.cc ('k') | net/quic/core/quic_multipath_received_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698