Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: net/quic/core/quic_one_block_arena_test.cc

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_multipath_sent_packet_manager_test.cc ('k') | net/quic/core/quic_packet_creator_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_one_block_arena_test.cc
diff --git a/net/quic/core/quic_one_block_arena_test.cc b/net/quic/core/quic_one_block_arena_test.cc
index 3f636327779673ee43d9408f882e73c432aaffe9..15ff0c672116449ff80b046f22ae17bbd5ed3d58 100644
--- a/net/quic/core/quic_one_block_arena_test.cc
+++ b/net/quic/core/quic_one_block_arena_test.cc
@@ -7,6 +7,7 @@
#include "net/quic/core/interval_set.h"
#include "net/quic/core/quic_flags.h"
#include "net/quic/core/quic_utils.h"
+#include "net/quic/test_tools/quic_test_utils.h"
#include "net/test/gtest_util.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -33,8 +34,8 @@ TEST(QuicOneBlockArenaTest, Exhaust) {
EXPECT_TRUE(ptr.is_from_arena());
}
QuicArenaScopedPtr<TestObject> ptr;
- EXPECT_DFATAL(ptr = arena.New<TestObject>(),
- "Ran out of space in QuicOneBlockArena");
+ EXPECT_QUIC_BUG(ptr = arena.New<TestObject>(),
+ "Ran out of space in QuicOneBlockArena");
EXPECT_FALSE(ptr.is_from_arena());
}
« no previous file with comments | « net/quic/core/quic_multipath_sent_packet_manager_test.cc ('k') | net/quic/core/quic_packet_creator_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698