Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: net/quic/core/quic_flow_controller_test.cc

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/core/quic_connection_test.cc ('k') | net/quic/core/quic_framer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/quic_flow_controller.h" 5 #include "net/quic/core/quic_flow_controller.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 EXPECT_FALSE(flow_controller_->IsBlocked()); 75 EXPECT_FALSE(flow_controller_->IsBlocked());
76 EXPECT_EQ(send_window_, flow_controller_->SendWindowSize()); 76 EXPECT_EQ(send_window_, flow_controller_->SendWindowSize());
77 77
78 // Updating with a smaller offset doesn't change anything. 78 // Updating with a smaller offset doesn't change anything.
79 EXPECT_FALSE(flow_controller_->UpdateSendWindowOffset(send_window_ / 10)); 79 EXPECT_FALSE(flow_controller_->UpdateSendWindowOffset(send_window_ / 10));
80 EXPECT_EQ(send_window_, flow_controller_->SendWindowSize()); 80 EXPECT_EQ(send_window_, flow_controller_->SendWindowSize());
81 81
82 // Try to send more bytes, violating flow control. 82 // Try to send more bytes, violating flow control.
83 EXPECT_CALL(connection_, 83 EXPECT_CALL(connection_,
84 CloseConnection(QUIC_FLOW_CONTROL_SENT_TOO_MUCH_DATA, _, _)); 84 CloseConnection(QUIC_FLOW_CONTROL_SENT_TOO_MUCH_DATA, _, _));
85 EXPECT_DFATAL(flow_controller_->AddBytesSent(send_window_ * 10), 85 EXPECT_QUIC_BUG(
86 base::StringPrintf("Trying to send an extra %" PRIu64 " bytes", 86 flow_controller_->AddBytesSent(send_window_ * 10),
87 send_window_ * 10)); 87 base::StringPrintf("Trying to send an extra %" PRIu64 " bytes",
88 send_window_ * 10));
88 EXPECT_TRUE(flow_controller_->IsBlocked()); 89 EXPECT_TRUE(flow_controller_->IsBlocked());
89 EXPECT_EQ(0u, flow_controller_->SendWindowSize()); 90 EXPECT_EQ(0u, flow_controller_->SendWindowSize());
90 } 91 }
91 92
92 TEST_F(QuicFlowControllerTest, ReceivingBytes) { 93 TEST_F(QuicFlowControllerTest, ReceivingBytes) {
93 Initialize(); 94 Initialize();
94 95
95 EXPECT_FALSE(flow_controller_->IsBlocked()); 96 EXPECT_FALSE(flow_controller_->IsBlocked());
96 EXPECT_FALSE(flow_controller_->FlowControlViolation()); 97 EXPECT_FALSE(flow_controller_->FlowControlViolation());
97 EXPECT_EQ(kInitialSessionFlowControlWindowForTest, 98 EXPECT_EQ(kInitialSessionFlowControlWindowForTest,
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 EXPECT_FALSE(flow_controller_->FlowControlViolation()); 367 EXPECT_FALSE(flow_controller_->FlowControlViolation());
367 368
368 QuicByteCount new_threshold = 369 QuicByteCount new_threshold =
369 QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get()); 370 QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get());
370 371
371 EXPECT_EQ(new_threshold, threshold); 372 EXPECT_EQ(new_threshold, threshold);
372 } 373 }
373 374
374 } // namespace test 375 } // namespace test
375 } // namespace net 376 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/core/quic_connection_test.cc ('k') | net/quic/core/quic_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698