Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2248283008: Fix recursion bug in blocking a fetch and add a test (Closed)

Created:
4 years, 4 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix recursion bug in blocking a fetch and add a test BUG=546953 Committed: https://crrev.com/ff93b14cb47f92464988ea507d938ca5fe63d909 Cr-Commit-Position: refs/heads/master@{#413176}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unintentional change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M headless/public/util/generic_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M headless/public/util/generic_url_request_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M headless/public/util/generic_url_request_job_test.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M headless/public/util/managed_dispatch_url_request_job.h View 1 chunk +2 lines, -0 lines 0 comments Download
M headless/public/util/testing/generic_url_request_mocks.h View 1 chunk +4 lines, -0 lines 0 comments Download
M headless/public/util/testing/generic_url_request_mocks.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M headless/public/util/url_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
alex clarke (OOO till 29th)
PTAL :)
4 years, 4 months ago (2016-08-19 16:25:40 UTC) #4
Sami
https://codereview.chromium.org/2248283008/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/DEPS File third_party/WebKit/Source/platform/scheduler/renderer/DEPS (right): https://codereview.chromium.org/2248283008/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/DEPS#newcode2 third_party/WebKit/Source/platform/scheduler/renderer/DEPS:2: \"+platform/scheduler/base\", Probably didn't mean to change these?
4 years, 4 months ago (2016-08-19 16:29:19 UTC) #6
alex clarke (OOO till 29th)
PTAL https://codereview.chromium.org/2248283008/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/DEPS File third_party/WebKit/Source/platform/scheduler/renderer/DEPS (right): https://codereview.chromium.org/2248283008/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/DEPS#newcode2 third_party/WebKit/Source/platform/scheduler/renderer/DEPS:2: \"+platform/scheduler/base\", On 2016/08/19 16:29:18, Sami wrote: > Probably ...
4 years, 4 months ago (2016-08-19 16:40:39 UTC) #7
Sami
lgtm.
4 years, 4 months ago (2016-08-19 16:42:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248283008/20001
4 years, 4 months ago (2016-08-19 16:47:40 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 17:25:27 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 17:27:52 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff93b14cb47f92464988ea507d938ca5fe63d909
Cr-Commit-Position: refs/heads/master@{#413176}

Powered by Google App Engine
This is Rietveld 408576698