headless/public/util/generic_url_request_job.h - Issue 2248283008: Fix recursion bug in blocking a fetch and add a test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/public/util/generic_url_request_job.h

Issue 2248283008: Fix recursion bug in blocking a fetch and add a test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unintentional change Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: headless/public/util/generic_url_request_job.h

diff --git a/headless/public/util/generic_url_request_job.h b/headless/public/util/generic_url_request_job.h

index 2890a6eba65b92cab4537989a63326a594016933..63e5d8ee192db6ff908a89a2f694a7749db1ca7d 100644

--- a/headless/public/util/generic_url_request_job.h

+++ b/headless/public/util/generic_url_request_job.h

@@ -95,7 +95,7 @@ class GenericURLRequestJob : public ManagedDispatchURLRequestJob,

bool GetCharset(std::string* charset) override;

// URLFetcher::FetchResultListener implementation:

- void OnStartError(net::Error error) override;

+ void OnFetchStartError(net::Error error) override;

void OnFetchComplete(const GURL& final_url,

int http_response_code,

scoped_refptr<net::HttpResponseHeaders> response_headers,

« no previous file with comments | « no previous file | headless/public/util/generic_url_request_job.cc » ('j') | no next file with comments »