headless/public/util/managed_dispatch_url_request_job.h - Issue 2248283008: Fix recursion bug in blocking a fetch and add a test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/public/util/managed_dispatch_url_request_job.h

Issue 2248283008: Fix recursion bug in blocking a fetch and add a test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unintentional change Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « headless/public/util/generic_url_request_job_test.cc ('k') | headless/public/util/testing/generic_url_request_mocks.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: headless/public/util/managed_dispatch_url_request_job.h

diff --git a/headless/public/util/managed_dispatch_url_request_job.h b/headless/public/util/managed_dispatch_url_request_job.h

index 5e518b2edab44304e65d6640b52d5b1bea234c21..3903d2a96a0f00b2447296ef3265bd0c42250f28 100644

--- a/headless/public/util/managed_dispatch_url_request_job.h

+++ b/headless/public/util/managed_dispatch_url_request_job.h

@@ -27,9 +27,11 @@ class ManagedDispatchURLRequestJob : public net::URLRequestJob {

// Tells the net::URLRequestJob that the data has been fetched and is ready to

// be consumed.

+ // Virtual for FakeManagedDispatchURLRequestJob.

virtual void OnHeadersComplete();

// Tells the net::URLRequestJob that the fetch failed.

+ // Virtual for FakeManagedDispatchURLRequestJob.

virtual void OnStartError(net::Error error);

protected:

« no previous file with comments | « headless/public/util/generic_url_request_job_test.cc ('k') | headless/public/util/testing/generic_url_request_mocks.h » ('j') | no next file with comments »