headless/public/util/testing/generic_url_request_mocks.h - Issue 2248283008: Fix recursion bug in blocking a fetch and add a test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/public/util/testing/generic_url_request_mocks.h

Issue 2248283008: Fix recursion bug in blocking a fetch and add a test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unintentional change Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « headless/public/util/managed_dispatch_url_request_job.h ('k') | headless/public/util/testing/generic_url_request_mocks.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: headless/public/util/testing/generic_url_request_mocks.h

diff --git a/headless/public/util/testing/generic_url_request_mocks.h b/headless/public/util/testing/generic_url_request_mocks.h

index 922b2f91ef3ff4b82542f3acc7ec3699524e23f6..0af68d08f242326820410b3c9a2561a236f8672e 100644

--- a/headless/public/util/testing/generic_url_request_mocks.h

+++ b/headless/public/util/testing/generic_url_request_mocks.h

@@ -44,7 +44,11 @@ class MockGenericURLRequestJobDelegate : public GenericURLRequestJob::Delegate {

const std::string& mime_type,

int http_response_code) override;

+ void SetShouldBlock(bool should_block) { should_block_ = should_block; }

private:

+ bool should_block_;

DISALLOW_COPY_AND_ASSIGN(MockGenericURLRequestJobDelegate);

};