Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: headless/public/util/testing/generic_url_request_mocks.cc

Issue 2248283008: Fix recursion bug in blocking a fetch and add a test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unintentional change Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/public/util/testing/generic_url_request_mocks.h ('k') | headless/public/util/url_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/util/testing/generic_url_request_mocks.cc
diff --git a/headless/public/util/testing/generic_url_request_mocks.cc b/headless/public/util/testing/generic_url_request_mocks.cc
index b23796c597734c817449ce1602ae0ae35896ea15..4060950e122d886af2c6710d5145a881271251bf 100644
--- a/headless/public/util/testing/generic_url_request_mocks.cc
+++ b/headless/public/util/testing/generic_url_request_mocks.cc
@@ -13,14 +13,17 @@ class URLRequestJob;
namespace headless {
// MockGenericURLRequestJobDelegate
-MockGenericURLRequestJobDelegate::MockGenericURLRequestJobDelegate() {}
+MockGenericURLRequestJobDelegate::MockGenericURLRequestJobDelegate()
+ : should_block_(false) {}
MockGenericURLRequestJobDelegate::~MockGenericURLRequestJobDelegate() {}
bool MockGenericURLRequestJobDelegate::BlockOrRewriteRequest(
const GURL& url,
const std::string& referrer,
GenericURLRequestJob::RewriteCallback callback) {
- return false;
+ if (should_block_)
+ callback(GenericURLRequestJob::RewriteResult::kDeny, GURL());
+ return should_block_;
}
const GenericURLRequestJob::HttpResponse*
« no previous file with comments | « headless/public/util/testing/generic_url_request_mocks.h ('k') | headless/public/util/url_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698