headless/public/util/generic_url_request_job.cc - Issue 2248283008: Fix recursion bug in blocking a fetch and add a test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/public/util/generic_url_request_job.cc

Issue 2248283008: Fix recursion bug in blocking a fetch and add a test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unintentional change Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: headless/public/util/generic_url_request_job.cc

diff --git a/headless/public/util/generic_url_request_job.cc b/headless/public/util/generic_url_request_job.cc

index c7cefc782e8a53c39fcf0bae7f5bb42dcbb87d9a..e36742768afb3930e92a722682728f95d24d6242 100644

--- a/headless/public/util/generic_url_request_job.cc

+++ b/headless/public/util/generic_url_request_job.cc

@@ -126,8 +126,8 @@ void GenericURLRequestJob::OnCookiesAvailable(

}

-void GenericURLRequestJob::OnStartError(net::Error error) {

- DispatchStartError(error);

+void GenericURLRequestJob::OnFetchStartError(net::Error error) {

+ OnStartError(error);

}

void GenericURLRequestJob::OnFetchComplete(

« no previous file with comments | « headless/public/util/generic_url_request_job.h ('k') | headless/public/util/generic_url_request_job_test.cc » ('j') | no next file with comments »