Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: headless/public/util/generic_url_request_job_test.cc

Issue 2248283008: Fix recursion bug in blocking a fetch and add a test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unintentional change Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/public/util/generic_url_request_job_test.cc
diff --git a/headless/public/util/generic_url_request_job_test.cc b/headless/public/util/generic_url_request_job_test.cc
index e687a6864191674762f2541c0c235741033337a7..74d35940d886f84979f3bb689a7dff8cd5e89e41 100644
--- a/headless/public/util/generic_url_request_job_test.cc
+++ b/headless/public/util/generic_url_request_job_test.cc
@@ -343,4 +343,20 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
EXPECT_THAT(fetch_request_, MatchesJson(expected_request_json));
}
+TEST_F(GenericURLRequestJobTest, DelegateBlocksLoading) {
+ std::string reply =
+ "{\"url\":\"https://example.com\","
+ " \"http_response_code\":200,"
+ " \"data\":\"Reply\","
+ " \"headers\":{\"Content-Type\":\"text/html; charset=UTF-8\"}}";
+
+ job_delegate_.SetShouldBlock(true);
+
+ std::unique_ptr<net::URLRequest> request(
+ CreateAndCompleteJob(GURL("https://example.com"), reply));
+
+ EXPECT_EQ(net::URLRequestStatus::FAILED, request->status().status());
+ EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request->status().error());
+}
+
} // namespace headless
« no previous file with comments | « headless/public/util/generic_url_request_job.cc ('k') | headless/public/util/managed_dispatch_url_request_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698