Push v8::Isolate into CFXJS_Engine class

Push v8::Isolate into CFXJS_Engine class

Nearly all the "loose" functions in FXJS become methods on
the CFJXS_Engine.

This is the "missing link" wrt some layering violatons that
have been around forever. We can stop passing &m_ variables
from CJS_ down into FXJS Initialization as a result.

Committed: https://pdfium.googlesource.com/pdfium/+/b4694249b336d1c0bea9222880b49dcf9284791d

[Tom Sepez, 2016-08-15 16:54:38]

Description was changed from

==========
Push v8::Isolate into new CFXJS_Engine class

This is the "missing link" wrt some layering violatons that
have been around forever.
==========

to

==========
Push v8::Isolate into CFXJS_Engine class

Nearly all the "loose" functions in FXJS become methods on
the CFJXS_Engine.

This is the "missing link" wrt some layering violatons that
have been around forever. We can stop passing &m_ variables from CJS_ down into
FXJS Initialization as a result.
==========

[Tom Sepez, 2016-08-15 16:57:38]

Description was changed from

==========
Push v8::Isolate into CFXJS_Engine class

Nearly all the "loose" functions in FXJS become methods on
the CFJXS_Engine.

This is the "missing link" wrt some layering violatons that
have been around forever. We can stop passing &m_ variables from CJS_ down into
FXJS Initialization as a result.
==========

to

==========
Push v8::Isolate into CFXJS_Engine class

Nearly all the "loose" functions in FXJS become methods on
the CFJXS_Engine.

This is the "missing link" wrt some layering violatons that
have been around forever. We can stop passing &m_ variables
from CJS_ down into FXJS Initialization as a result.
==========

[Tom Sepez, 2016-08-15 20:05:12]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 20:05:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-15 20:10:28]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-08-15 20:10:29]

Dan, follow-on from previous patch.  I couldn't find a way to break this into
pieces since it seems to flow everywhere.

[dsinclair, 2016-08-15 20:38:38]

lgtm w/ question and nits.

https://codereview.chromium.org/2245863002/diff/120001/fxjs/fxjs_v8.cpp
File fxjs/fxjs_v8.cpp (right):

https://codereview.chromium.org/2245863002/diff/120001/fxjs/fxjs_v8.cpp#newco...
fxjs/fxjs_v8.cpp:225: CFXJS_Engine::CFXJS_Engine() : m_isolate(nullptr) {}
Now that most of this is moved over, should we rename the fxjs_v8.* to
cfxjs_engine.*?

https://codereview.chromium.org/2245863002/diff/120001/fxjs/fxjs_v8.cpp#newco...
fxjs/fxjs_v8.cpp:426: // static
statics at the top

https://codereview.chromium.org/2245863002/diff/120001/fxjs/fxjs_v8.cpp#newco...
fxjs/fxjs_v8.cpp:514: // static
ditto

https://codereview.chromium.org/2245863002/diff/120001/fxjs/fxjs_v8.cpp#newco...
fxjs/fxjs_v8.cpp:567: // static
...

[Tom Sepez, 2016-08-15 20:46:15]

https://codereview.chromium.org/2245863002/diff/120001/fxjs/fxjs_v8.cpp
File fxjs/fxjs_v8.cpp (right):

https://codereview.chromium.org/2245863002/diff/120001/fxjs/fxjs_v8.cpp#newco...
fxjs/fxjs_v8.cpp:225: CFXJS_Engine::CFXJS_Engine() : m_isolate(nullptr) {}
On 2016/08/15 20:38:37, dsinclair wrote:
> Now that most of this is moved over, should we rename the fxjs_v8.* to
> cfxjs_engine.*?

Probably someday.  Or cfxjs_engine_v8, since there could be another adapter in
the future, given some layering cleanup.

https://codereview.chromium.org/2245863002/diff/120001/fxjs/fxjs_v8.cpp#newco...
fxjs/fxjs_v8.cpp:426: // static
On 2016/08/15 20:38:37, dsinclair wrote:
> statics at the top

Done.

https://codereview.chromium.org/2245863002/diff/120001/fxjs/fxjs_v8.cpp#newco...
fxjs/fxjs_v8.cpp:567: // static
On 2016/08/15 20:38:37, dsinclair wrote:
> ...

Done.

[Tom Sepez, 2016-08-15 20:46:26]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-08-15 20:46:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2245863002/#ps140001
(title: "Statics near top")

[commit-bot: I haz the power, 2016-08-15 20:46:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 21:39:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 21:39:39]

Try jobs failed on following builders:
  mac on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/1670)

[Tom Sepez, 2016-08-15 23:14:10]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 23:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-15 23:32:28]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-08-15 23:32:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2245863002/#ps180001
(title: "Null isolate before letting CFXJS_Engine dtor invoked")

[commit-bot: I haz the power, 2016-08-15 23:32:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:44:58]

Description was changed from

==========
Push v8::Isolate into CFXJS_Engine class

Nearly all the "loose" functions in FXJS become methods on
the CFJXS_Engine.

This is the "missing link" wrt some layering violatons that
have been around forever. We can stop passing &m_ variables
from CJS_ down into FXJS Initialization as a result.
==========

to

==========
Push v8::Isolate into CFXJS_Engine class

Nearly all the "loose" functions in FXJS become methods on
the CFJXS_Engine.

This is the "missing link" wrt some layering violatons that
have been around forever. We can stop passing &m_ variables
from CJS_ down into FXJS Initialization as a result.

Committed:
https://pdfium.googlesource.com/pdfium/+/b4694249b336d1c0bea9222880b49dcf9284...
==========

[commit-bot: I haz the power, 2016-08-15 23:44:59]

Committed patchset #10 (id:180001) as
https://pdfium.googlesource.com/pdfium/+/b4694249b336d1c0bea9222880b49dcf9284...