Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Side by Side Diff: fpdfsdk/javascript/JS_Runtime_Stub.cpp

Issue 2245863002: Push v8::Isolate into CFXJS_Engine class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Null isolate before letting CFXJS_Engine dtor invoked Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/javascript/JS_Object.cpp ('k') | fpdfsdk/javascript/JS_Value.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "fpdfsdk/include/fsdk_mgr.h" 9 #include "fpdfsdk/include/fsdk_mgr.h"
10 #include "fpdfsdk/javascript/ijs_context.h" 10 #include "fpdfsdk/javascript/ijs_context.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 #ifdef PDF_ENABLE_XFA 140 #ifdef PDF_ENABLE_XFA
141 FX_BOOL GetValueByName(const CFX_ByteStringC&, CFXJSE_Value*) override { 141 FX_BOOL GetValueByName(const CFX_ByteStringC&, CFXJSE_Value*) override {
142 return FALSE; 142 return FALSE;
143 } 143 }
144 144
145 FX_BOOL SetValueByName(const CFX_ByteStringC&, CFXJSE_Value*) override { 145 FX_BOOL SetValueByName(const CFX_ByteStringC&, CFXJSE_Value*) override {
146 return FALSE; 146 return FALSE;
147 } 147 }
148 #endif // PDF_ENABLE_XFA 148 #endif // PDF_ENABLE_XFA
149 149
150 int Execute(const CFX_WideString& script, CFX_WideString* info) override { 150 int ExecuteScript(const CFX_WideString& script,
151 CFX_WideString* info) override {
151 return 0; 152 return 0;
152 } 153 }
153 154
154 protected: 155 protected:
155 CPDFSDK_Document* m_pDoc; 156 CPDFSDK_Document* m_pDoc;
156 std::unique_ptr<CJS_ContextStub> m_pContext; 157 std::unique_ptr<CJS_ContextStub> m_pContext;
157 }; 158 };
158 159
159 // static 160 // static
160 void IJS_Runtime::Initialize(unsigned int slot, void* isolate) {} 161 void IJS_Runtime::Initialize(unsigned int slot, void* isolate) {}
161 162
162 // static 163 // static
163 void IJS_Runtime::Destroy() {} 164 void IJS_Runtime::Destroy() {}
164 165
165 // static 166 // static
166 IJS_Runtime* IJS_Runtime::Create(CPDFDoc_Environment* pEnv) { 167 IJS_Runtime* IJS_Runtime::Create(CPDFDoc_Environment* pEnv) {
167 return new CJS_RuntimeStub; 168 return new CJS_RuntimeStub;
168 } 169 }
OLDNEW
« no previous file with comments | « fpdfsdk/javascript/JS_Object.cpp ('k') | fpdfsdk/javascript/JS_Value.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698