fpdfsdk/javascript/Field.h - Issue 2245863002: Push v8::Isolate into CFXJS_Engine class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/Field.h

Issue 2245863002: Push v8::Isolate into CFXJS_Engine class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Null isolate before letting CFXJS_Engine dtor invoked Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/Field.h

diff --git a/fpdfsdk/javascript/Field.h b/fpdfsdk/javascript/Field.h

index 3d1b0ff876f9eecaa64e05a93dc960658e937b98..0ffdbd4ba4c32f357858fa79c325be92073b040a 100644

--- a/fpdfsdk/javascript/Field.h

+++ b/fpdfsdk/javascript/Field.h

@@ -435,7 +435,6 @@ class Field : public CJS_EmbedObj {

FX_BOOL AttachField(Document* pDocument, const CFX_WideString& csFieldName);

void SetDelay(FX_BOOL bDelay);

- void SetIsolate(v8::Isolate* isolate) { m_isolate = isolate; }

protected:

void ParseFieldName(const std::wstring& strFieldNameParsed,

@@ -464,9 +463,7 @@ class Field : public CJS_EmbedObj {

CFX_WideString m_FieldName;

int m_nFormControlIndex;

FX_BOOL m_bCanSet;

FX_BOOL m_bDelay;

- v8::Isolate* m_isolate;

};

class CJS_Field : public CJS_Object {

« no previous file with comments | « fpdfsdk/javascript/Document.cpp ('k') | fpdfsdk/javascript/Field.cpp » ('j') | no next file with comments »