fpdfsdk/javascript/JS_Object.cpp - Issue 2245863002: Push v8::Isolate into CFXJS_Engine class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/JS_Object.cpp

Issue 2245863002: Push v8::Isolate into CFXJS_Engine class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Null isolate before letting CFXJS_Engine dtor invoked Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/JS_Object.cpp

diff --git a/fpdfsdk/javascript/JS_Object.cpp b/fpdfsdk/javascript/JS_Object.cpp

index d67ceeb0c615195bee6267c0209cf5386c17677e..3de0eceba35416bc5d89afe90741ee0c12319a2f 100644

--- a/fpdfsdk/javascript/JS_Object.cpp

+++ b/fpdfsdk/javascript/JS_Object.cpp

@@ -19,7 +19,7 @@ void FreeObject(const v8::WeakCallbackInfo<CJS_Object>& data) {

CJS_Object* pJSObj = data.GetParameter();

pJSObj->ExitInstance();

delete pJSObj;

- FXJS_FreePrivate(data.GetInternalField(0));

+ CFXJS_Engine::FreeObjectPrivate(data.GetInternalField(0));

}

void DisposeObject(const v8::WeakCallbackInfo<CJS_Object>& data) {

« no previous file with comments | « fpdfsdk/javascript/JS_EventHandler.cpp ('k') | fpdfsdk/javascript/JS_Runtime_Stub.cpp » ('j') | no next file with comments »