Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: fpdfsdk/javascript/color.cpp

Issue 2245863002: Push v8::Isolate into CFXJS_Engine class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Null isolate before letting CFXJS_Engine dtor invoked Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/javascript/cjs_runtime.cpp ('k') | fpdfsdk/javascript/global.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/javascript/color.h" 7 #include "fpdfsdk/javascript/color.h"
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 m_crLTGray = CPWL_Color(COLORTYPE_GRAY, 0.75); 55 m_crLTGray = CPWL_Color(COLORTYPE_GRAY, 0.75);
56 } 56 }
57 57
58 color::~color() {} 58 color::~color() {}
59 59
60 void color::ConvertPWLColorToArray(CJS_Runtime* pRuntime, 60 void color::ConvertPWLColorToArray(CJS_Runtime* pRuntime,
61 const CPWL_Color& color, 61 const CPWL_Color& color,
62 CJS_Array* array) { 62 CJS_Array* array) {
63 switch (color.nColorType) { 63 switch (color.nColorType) {
64 case COLORTYPE_TRANSPARENT: 64 case COLORTYPE_TRANSPARENT:
65 array->SetElement(pRuntime->GetIsolate(), 0, CJS_Value(pRuntime, "T")); 65 array->SetElement(pRuntime, 0, CJS_Value(pRuntime, "T"));
66 break; 66 break;
67 case COLORTYPE_GRAY: 67 case COLORTYPE_GRAY:
68 array->SetElement(pRuntime->GetIsolate(), 0, CJS_Value(pRuntime, "G")); 68 array->SetElement(pRuntime, 0, CJS_Value(pRuntime, "G"));
69 array->SetElement(pRuntime->GetIsolate(), 1, 69 array->SetElement(pRuntime, 1, CJS_Value(pRuntime, color.fColor1));
70 CJS_Value(pRuntime, color.fColor1));
71 break; 70 break;
72 case COLORTYPE_RGB: 71 case COLORTYPE_RGB:
73 array->SetElement(pRuntime->GetIsolate(), 0, CJS_Value(pRuntime, "RGB")); 72 array->SetElement(pRuntime, 0, CJS_Value(pRuntime, "RGB"));
74 array->SetElement(pRuntime->GetIsolate(), 1, 73 array->SetElement(pRuntime, 1, CJS_Value(pRuntime, color.fColor1));
75 CJS_Value(pRuntime, color.fColor1)); 74 array->SetElement(pRuntime, 2, CJS_Value(pRuntime, color.fColor2));
76 array->SetElement(pRuntime->GetIsolate(), 2, 75 array->SetElement(pRuntime, 3, CJS_Value(pRuntime, color.fColor3));
77 CJS_Value(pRuntime, color.fColor2));
78 array->SetElement(pRuntime->GetIsolate(), 3,
79 CJS_Value(pRuntime, color.fColor3));
80 break; 76 break;
81 case COLORTYPE_CMYK: 77 case COLORTYPE_CMYK:
82 array->SetElement(pRuntime->GetIsolate(), 0, CJS_Value(pRuntime, "CMYK")); 78 array->SetElement(pRuntime, 0, CJS_Value(pRuntime, "CMYK"));
83 array->SetElement(pRuntime->GetIsolate(), 1, 79 array->SetElement(pRuntime, 1, CJS_Value(pRuntime, color.fColor1));
84 CJS_Value(pRuntime, color.fColor1)); 80 array->SetElement(pRuntime, 2, CJS_Value(pRuntime, color.fColor2));
85 array->SetElement(pRuntime->GetIsolate(), 2, 81 array->SetElement(pRuntime, 3, CJS_Value(pRuntime, color.fColor3));
86 CJS_Value(pRuntime, color.fColor2)); 82 array->SetElement(pRuntime, 4, CJS_Value(pRuntime, color.fColor4));
87 array->SetElement(pRuntime->GetIsolate(), 3,
88 CJS_Value(pRuntime, color.fColor3));
89 array->SetElement(pRuntime->GetIsolate(), 4,
90 CJS_Value(pRuntime, color.fColor4));
91 break; 83 break;
92 } 84 }
93 } 85 }
94 86
95 void color::ConvertArrayToPWLColor(CJS_Runtime* pRuntime, 87 void color::ConvertArrayToPWLColor(CJS_Runtime* pRuntime,
96 const CJS_Array& array, 88 const CJS_Array& array,
97 CPWL_Color* color) { 89 CPWL_Color* color) {
98 int nArrayLen = array.GetLength(); 90 int nArrayLen = array.GetLength(pRuntime);
99 if (nArrayLen < 1) 91 if (nArrayLen < 1)
100 return; 92 return;
101 93
102 CJS_Value value(pRuntime); 94 CJS_Value value(pRuntime);
103 array.GetElement(pRuntime->GetIsolate(), 0, value); 95 array.GetElement(pRuntime, 0, value);
104 CFX_ByteString sSpace = value.ToCFXByteString(pRuntime->GetIsolate()); 96 CFX_ByteString sSpace = value.ToCFXByteString(pRuntime);
105 97
106 double d1 = 0; 98 double d1 = 0;
107 double d2 = 0; 99 double d2 = 0;
108 double d3 = 0; 100 double d3 = 0;
109 double d4 = 0; 101 double d4 = 0;
110 102
111 if (nArrayLen > 1) { 103 if (nArrayLen > 1) {
112 array.GetElement(pRuntime->GetIsolate(), 1, value); 104 array.GetElement(pRuntime, 1, value);
113 d1 = value.ToDouble(pRuntime->GetIsolate()); 105 d1 = value.ToDouble(pRuntime);
114 } 106 }
115 107
116 if (nArrayLen > 2) { 108 if (nArrayLen > 2) {
117 array.GetElement(pRuntime->GetIsolate(), 2, value); 109 array.GetElement(pRuntime, 2, value);
118 d2 = value.ToDouble(pRuntime->GetIsolate()); 110 d2 = value.ToDouble(pRuntime);
119 } 111 }
120 112
121 if (nArrayLen > 3) { 113 if (nArrayLen > 3) {
122 array.GetElement(pRuntime->GetIsolate(), 3, value); 114 array.GetElement(pRuntime, 3, value);
123 d3 = value.ToDouble(pRuntime->GetIsolate()); 115 d3 = value.ToDouble(pRuntime);
124 } 116 }
125 117
126 if (nArrayLen > 4) { 118 if (nArrayLen > 4) {
127 array.GetElement(pRuntime->GetIsolate(), 4, value); 119 array.GetElement(pRuntime, 4, value);
128 d4 = value.ToDouble(pRuntime->GetIsolate()); 120 d4 = value.ToDouble(pRuntime);
129 } 121 }
130 122
131 if (sSpace == "T") { 123 if (sSpace == "T") {
132 *color = CPWL_Color(COLORTYPE_TRANSPARENT); 124 *color = CPWL_Color(COLORTYPE_TRANSPARENT);
133 } else if (sSpace == "G") { 125 } else if (sSpace == "G") {
134 *color = CPWL_Color(COLORTYPE_GRAY, (FX_FLOAT)d1); 126 *color = CPWL_Color(COLORTYPE_GRAY, (FX_FLOAT)d1);
135 } else if (sSpace == "RGB") { 127 } else if (sSpace == "RGB") {
136 *color = 128 *color =
137 CPWL_Color(COLORTYPE_RGB, (FX_FLOAT)d1, (FX_FLOAT)d2, (FX_FLOAT)d3); 129 CPWL_Color(COLORTYPE_RGB, (FX_FLOAT)d1, (FX_FLOAT)d2, (FX_FLOAT)d3);
138 } else if (sSpace == "CMYK") { 130 } else if (sSpace == "CMYK") {
139 *color = CPWL_Color(COLORTYPE_CMYK, (FX_FLOAT)d1, (FX_FLOAT)d2, 131 *color = CPWL_Color(COLORTYPE_CMYK, (FX_FLOAT)d1, (FX_FLOAT)d2,
140 (FX_FLOAT)d3, (FX_FLOAT)d4); 132 (FX_FLOAT)d3, (FX_FLOAT)d4);
141 } 133 }
142 } 134 }
143 135
144 #define JS_IMPLEMENT_COLORPROP(prop, var) \ 136 #define JS_IMPLEMENT_COLORPROP(prop, var) \
145 FX_BOOL color::prop(IJS_Context* cc, CJS_PropValue& vp, \ 137 FX_BOOL color::prop(IJS_Context* cc, CJS_PropValue& vp, \
146 CFX_WideString& sError) { \ 138 CFX_WideString& sError) { \
147 CJS_Runtime* pRuntime = CJS_Runtime::FromContext(cc); \ 139 CJS_Runtime* pRuntime = CJS_Runtime::FromContext(cc); \
148 CJS_Array array; \ 140 CJS_Array array; \
149 if (vp.IsGetting()) { \ 141 if (vp.IsGetting()) { \
150 ConvertPWLColorToArray(pRuntime, var, &array); \ 142 ConvertPWLColorToArray(pRuntime, var, &array); \
151 vp << array; \ 143 vp << array; \
152 } else { \ 144 } else { \
153 if (!vp.GetJSValue()->ConvertToArray(pRuntime->GetIsolate(), array)) \ 145 if (!vp.GetJSValue()->ConvertToArray(pRuntime, array)) \
154 return FALSE; \ 146 return FALSE; \
155 ConvertArrayToPWLColor(pRuntime, array, &var); \ 147 ConvertArrayToPWLColor(pRuntime, array, &var); \
156 } \ 148 } \
157 return TRUE; \ 149 return TRUE; \
158 } 150 }
159 151
160 JS_IMPLEMENT_COLORPROP(transparent, m_crTransparent) 152 JS_IMPLEMENT_COLORPROP(transparent, m_crTransparent)
161 JS_IMPLEMENT_COLORPROP(black, m_crBlack) 153 JS_IMPLEMENT_COLORPROP(black, m_crBlack)
162 JS_IMPLEMENT_COLORPROP(white, m_crWhite) 154 JS_IMPLEMENT_COLORPROP(white, m_crWhite)
163 JS_IMPLEMENT_COLORPROP(red, m_crRed) 155 JS_IMPLEMENT_COLORPROP(red, m_crRed)
164 JS_IMPLEMENT_COLORPROP(green, m_crGreen) 156 JS_IMPLEMENT_COLORPROP(green, m_crGreen)
165 JS_IMPLEMENT_COLORPROP(blue, m_crBlue) 157 JS_IMPLEMENT_COLORPROP(blue, m_crBlue)
166 JS_IMPLEMENT_COLORPROP(cyan, m_crCyan) 158 JS_IMPLEMENT_COLORPROP(cyan, m_crCyan)
167 JS_IMPLEMENT_COLORPROP(magenta, m_crMagenta) 159 JS_IMPLEMENT_COLORPROP(magenta, m_crMagenta)
168 JS_IMPLEMENT_COLORPROP(yellow, m_crYellow) 160 JS_IMPLEMENT_COLORPROP(yellow, m_crYellow)
169 JS_IMPLEMENT_COLORPROP(dkGray, m_crDKGray) 161 JS_IMPLEMENT_COLORPROP(dkGray, m_crDKGray)
170 JS_IMPLEMENT_COLORPROP(gray, m_crGray) 162 JS_IMPLEMENT_COLORPROP(gray, m_crGray)
171 JS_IMPLEMENT_COLORPROP(ltGray, m_crLTGray) 163 JS_IMPLEMENT_COLORPROP(ltGray, m_crLTGray)
172 164
173 FX_BOOL color::convert(IJS_Context* cc, 165 FX_BOOL color::convert(IJS_Context* cc,
174 const std::vector<CJS_Value>& params, 166 const std::vector<CJS_Value>& params,
175 CJS_Value& vRet, 167 CJS_Value& vRet,
176 CFX_WideString& sError) { 168 CFX_WideString& sError) {
177 int iSize = params.size(); 169 int iSize = params.size();
178 if (iSize < 2) 170 if (iSize < 2)
179 return FALSE; 171 return FALSE;
180 172
181 CJS_Runtime* pRuntime = CJS_Runtime::FromContext(cc); 173 CJS_Runtime* pRuntime = CJS_Runtime::FromContext(cc);
182 CJS_Array aSource; 174 CJS_Array aSource;
183 if (!params[0].ConvertToArray(pRuntime->GetIsolate(), aSource)) 175 if (!params[0].ConvertToArray(pRuntime, aSource))
184 return FALSE; 176 return FALSE;
185 177
186 CPWL_Color crSource; 178 CPWL_Color crSource;
187 ConvertArrayToPWLColor(pRuntime, aSource, &crSource); 179 ConvertArrayToPWLColor(pRuntime, aSource, &crSource);
188 180
189 CFX_ByteString sDestSpace = params[1].ToCFXByteString(pRuntime->GetIsolate()); 181 CFX_ByteString sDestSpace = params[1].ToCFXByteString(pRuntime);
190 int nColorType = COLORTYPE_TRANSPARENT; 182 int nColorType = COLORTYPE_TRANSPARENT;
191 183
192 if (sDestSpace == "T") { 184 if (sDestSpace == "T") {
193 nColorType = COLORTYPE_TRANSPARENT; 185 nColorType = COLORTYPE_TRANSPARENT;
194 } else if (sDestSpace == "G") { 186 } else if (sDestSpace == "G") {
195 nColorType = COLORTYPE_GRAY; 187 nColorType = COLORTYPE_GRAY;
196 } else if (sDestSpace == "RGB") { 188 } else if (sDestSpace == "RGB") {
197 nColorType = COLORTYPE_RGB; 189 nColorType = COLORTYPE_RGB;
198 } else if (sDestSpace == "CMYK") { 190 } else if (sDestSpace == "CMYK") {
199 nColorType = COLORTYPE_CMYK; 191 nColorType = COLORTYPE_CMYK;
(...skipping 11 matching lines...) Expand all
211 FX_BOOL color::equal(IJS_Context* cc, 203 FX_BOOL color::equal(IJS_Context* cc,
212 const std::vector<CJS_Value>& params, 204 const std::vector<CJS_Value>& params,
213 CJS_Value& vRet, 205 CJS_Value& vRet,
214 CFX_WideString& sError) { 206 CFX_WideString& sError) {
215 if (params.size() < 2) 207 if (params.size() < 2)
216 return FALSE; 208 return FALSE;
217 209
218 CJS_Runtime* pRuntime = CJS_Runtime::FromContext(cc); 210 CJS_Runtime* pRuntime = CJS_Runtime::FromContext(cc);
219 CJS_Array array1; 211 CJS_Array array1;
220 CJS_Array array2; 212 CJS_Array array2;
221 if (!params[0].ConvertToArray(pRuntime->GetIsolate(), array1)) 213 if (!params[0].ConvertToArray(pRuntime, array1))
222 return FALSE; 214 return FALSE;
223 if (!params[1].ConvertToArray(pRuntime->GetIsolate(), array2)) 215 if (!params[1].ConvertToArray(pRuntime, array2))
224 return FALSE; 216 return FALSE;
225 217
226 CPWL_Color color1; 218 CPWL_Color color1;
227 CPWL_Color color2; 219 CPWL_Color color2;
228 ConvertArrayToPWLColor(pRuntime, array1, &color1); 220 ConvertArrayToPWLColor(pRuntime, array1, &color1);
229 ConvertArrayToPWLColor(pRuntime, array2, &color2); 221 ConvertArrayToPWLColor(pRuntime, array2, &color2);
230 color1.ConvertColorType(color2.nColorType); 222 color1.ConvertColorType(color2.nColorType);
231 vRet = CJS_Value(pRuntime, color1 == color2); 223 vRet = CJS_Value(pRuntime, color1 == color2);
232 return TRUE; 224 return TRUE;
233 } 225 }
OLDNEW
« no previous file with comments | « fpdfsdk/javascript/cjs_runtime.cpp ('k') | fpdfsdk/javascript/global.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698