fpdfsdk/javascript/JS_Runtime_Stub.cpp - Issue 2245863002: Push v8::Isolate into CFXJS_Engine class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/JS_Runtime_Stub.cpp

Issue 2245863002: Push v8::Isolate into CFXJS_Engine class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Null isolate before letting CFXJS_Engine dtor invoked Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/JS_Runtime_Stub.cpp

diff --git a/fpdfsdk/javascript/JS_Runtime_Stub.cpp b/fpdfsdk/javascript/JS_Runtime_Stub.cpp

index 109be0acd6192f652ba8764b443fd1d0b2f4b980..98c641f750f00c26532aa304548fee8397ec9acc 100644

--- a/fpdfsdk/javascript/JS_Runtime_Stub.cpp

+++ b/fpdfsdk/javascript/JS_Runtime_Stub.cpp

@@ -147,7 +147,8 @@ class CJS_RuntimeStub final : public IJS_Runtime {

}

#endif // PDF_ENABLE_XFA

- int Execute(const CFX_WideString& script, CFX_WideString* info) override {

+ int ExecuteScript(const CFX_WideString& script,

+ CFX_WideString* info) override {

return 0;

}

« no previous file with comments | « fpdfsdk/javascript/JS_Object.cpp ('k') | fpdfsdk/javascript/JS_Value.h » ('j') | no next file with comments »